← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1753557] Re: i18n javascript on login page requires login (again)

 

Reviewed:  https://review.openstack.org/552789
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f494c6f2d475bfc936b78fda7ce11ed4d46c7224
Submitter: Zuul
Branch:    master

commit f494c6f2d475bfc936b78fda7ce11ed4d46c7224
Author: Shu Muto <shu.mutow@xxxxxxxxx>
Date:   Wed Mar 14 11:43:12 2018 +0900

    Fix Angular errors in openstack_auth
    
    Angular errors on login page are caused by loading ngdetails view.
    Although registration of URL for ngdetails is executed on top level
    of Horizon, ngdetails view is not needed to be loaded in login page,
    i.e. openstack_auth side.
    To fix this issue, this patch moves registration of URL for ngdetails
    into openstack_dashboard side.
    
    Change-Id: Ib039417b4e666c2341f17ac05fd7723bc758816c
    Closes-Bug: #1754133
    Closes-Bug: #1753557


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1753557

Title:
  i18n javascript on login page requires login (again)

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  https://bugs.launchpad.net/horizon/+bug/1708671 was marked as
  "Invalid"/Fixed, with the fix being this revert:
  https://git.openstack.org/cgit/openstack/horizon/commit/?h=stable/queens&id=c16ceb149c855411aec66d713eddc8d6c62f9b30

  However, it seems to have been reintroduced in
  https://git.openstack.org/cgit/openstack/horizon/commit/?h=stable/queens&id=077163a03c9aea08efd56251e49d69eb1cc4d093
  - after reverting this patch in my local installation it all seems
  happy again.

  This affects the queens release.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1753557/+subscriptions


References