← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1757112] Re: wrong variable name in context_processors.py

 

Reviewed:  https://review.openstack.org/554413
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f588b4ee2e73c754a7565928c47552e159a1666d
Submitter: Zuul
Branch:    master

commit f588b4ee2e73c754a7565928c47552e159a1666d
Author: Adrian Turjak <adriant@xxxxxxxxxxxxxxx>
Date:   Tue Mar 20 17:55:52 2018 +1300

    Fix wrong setting name for SHOW_KEYSTONE_V2_RC
    
    The user links patch didn't use the same setting
    variable name in context_processors.py, this fixes
    that.
    
    Closes-Bug: #1757112
    
    Change-Id: Ie0e516d82c2c1cdc1c343075393cdf9c336f8e5f


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1757112

Title:
  wrong variable name in context_processors.py

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  In the patch that added user menu links, the variable name for
  disabling v2 rc files was renamed by accident it seems in the
  context_processors.py module.

  https://github.com/openstack/horizon/commit/924239073ec8036265d13a3c6b09d6fa7865147f#diff-5a128d55603c030b687d1321df381ab0L100
  vs
  https://github.com/openstack/horizon/commit/924239073ec8036265d13a3c6b09d6fa7865147f#diff-5a128d55603c030b687d1321df381ab0R91

  Because of that the v2 download in the user dropdown wasn't being
  hidden correctly. The fix is easy.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1757112/+subscriptions


References