← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1756507] Re: The function _cleanup_running_deleted_instances repeat detach volume

 

Reviewed:  https://review.openstack.org/554090
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1a241d0fb374c8747e3712313417a4fa284a4e43
Submitter: Zuul
Branch:    master

commit 1a241d0fb374c8747e3712313417a4fa284a4e43
Author: zhengyao1 <zheng.yao1@xxxxxxxxxx>
Date:   Mon Mar 19 10:51:00 2018 +0800

    remove _cleanup_running_deleted_instances repeat detach volume
    
    the volumes already detached during the above _shutdown_instance() call.
    So detach is not requested from _cleanup_volumes() in this case. So the
    call change to self._cleanup_volumes(context, instance, bdms, detach=False).
    
    Change-Id: I833f259972dd2e0e6bb3bbaa0e5a78a93f59b076
    Closes-Bug: #1756507


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1756507

Title:
  The function _cleanup_running_deleted_instances repeat detach volume

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  https://git.openstack.org/cgit/openstack/nova/tree/nova/compute/manager.py#n7421,
  The volumes already detached during the above _shutdown_instance()
  call. So detach is not requested from _cleanup_volumes() in this case.
  So the call maybe change to self._cleanup_volumes(context, instance,
  bdms,detach=False).

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1756507/+subscriptions


References