yahoo-eng-team team mailing list archive

[OpenStack Infra <1724613@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/533396
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=02e357e7c2d2ccbab0a1f6b5a807d11f1ef72d46
Submitter: Zuul
Branch:    master

commit 02e357e7c2d2ccbab0a1f6b5a807d11f1ef72d46
Author: Tetsuro Nakamura <nakamura.tetsuro@xxxxxxxxxxxxx>
Date:   Sun Jan 14 17:09:05 2018 +0900

    Fix allocation_candidates not to ignore shared RPs
    
    When both the compute node resource provider and the shared
    resource provider have inventory in the same resource class,
    AllocationCandidates.get_by_filters didn't return an
    AllocationRequest including the shared resource provider.
    
    To fix the bug, this patch changes the function of
    _alloc_candidates_with_shared() to consider resources from
    non-sharing providers and resources from sharing providers
    at the same time.
    
    Change-Id: Iaf23f35f2f9a5d27a814ef5b94abed1a8b365bc3
    Closes-Bug: #1724613
    Related-Bug: #1731072


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1724613

Title:
  AllocationCandidates.get_by_filters ignores shared RPs when the RC
  exists in both places

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  When both the compute node resource provider and the shared resource
  provider have inventory in the same resource class,
  AllocationCandidates.get_by_filters will not return an
  AllocationRequest including the shared resource provider.

  Example:

   cnrp { VCPU: 24,
          MEMORY_MB: 2048,
          DISK_GB: 16 }
   ssrp { DISK_GB: 32 }

   AllocationCandidates.get_by_filters(
       resources={ VCPU: 1,
                   MEMORY_MB: 512,
                   DISK_GB: 2 } )

  Expected:

   allocation_requests: [
       { cnrp: { VCPU: 1,
                 MEMORY_MB: 512,
                 DISK_GB: 2 } },
       { cnrp: { VCPU: 1,
                 MEMORY_MB: 512 }
         ssrp: { DISK_GB: 2 } },
   ]

  Actual:

   allocation_requests: [
       { cnrp: { VCPU: 1,
                 MEMORY_MB: 512,
                 DISK_GB: 2 } }
   ]

  I will post a review shortly that demonstrates this.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1724613/+subscriptions