yahoo-eng-team team mailing list archive

[OpenStack Infra <1760017@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/557883
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4a78dccf70bf8c37b3586cedfe5a4f0fb0d45b96
Submitter: Zuul
Branch:    master

commit 4a78dccf70bf8c37b3586cedfe5a4f0fb0d45b96
Author: Takashi NATSUME <natsume.takashi@xxxxxxxxxxxxx>
Date:   Fri Mar 30 13:24:30 2018 +0900

    Remove mox in tests/unit/test_utils.py
    
    Replace mox with mock in nova/tests/unit/test_utils.py.
    The 'test_supports_direct_io' method is
    in the 'GetEndpointTestCase' class currently.
    But it should be in an isolated test class.
    So add the test class and move the method into it.
    
    Then split the method into methods for each test case
    to improve readability.
    
    Change-Id: Id2350529b3322dfa8f7c13ac8e5f85aaf3041082
    Implements: blueprint mox-removal
    Closes-Bug: #1760017


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1760017

Title:
  The 'test_supports_direct_io' method belongs a wrong test class

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  The 'test_supports_direct_io' method belongs the 'GetEndpointTestCase' class.
  But it should not be in the class because the class is for the 'get_endpoint' method.
  The 'test_supports_direct_io' method should be in an isolated class.

  https://github.com/openstack/nova/blob/942ed9b265b0f1fe4c237052030f2d73a3807b7a/nova/tests/unit/test_utils.py#L1337-L1436

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1760017/+subscriptions