yahoo-eng-team team mailing list archive

[Balazs Gibizer <balazs.gibizer@xxxxxxxxxxxx>]

Public bug reported:


Both notify_usage_exists() [1] and info_from_instance() [2] functions used in the notification code path get the system_metadata passed in. Instead we should use the instance.system_metadata directly  whenever it is possible.

[1] https://github.com/openstack/nova/blob/57d3b7093259b625672a98b0ff41643175f6cb82/nova/compute/utils.py#L278
[2]https://github.com/openstack/nova/blob/57d3b7093259b625672a98b0ff41643175f6cb82/nova/notifications/base.py#L382

** Affects: nova
     Importance: Low
         Status: New


** Tags: notifications

** Changed in: nova
   Importance: Undecided => Low

** Tags added: notifications

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1764390

Title:
  Replace passing system_metadata to notification functions with
  instance.system_metadata usage

Status in OpenStack Compute (nova):
  New

Bug description:
  
  Both notify_usage_exists() [1] and info_from_instance() [2] functions used in the notification code path get the system_metadata passed in. Instead we should use the instance.system_metadata directly  whenever it is possible.

  [1] https://github.com/openstack/nova/blob/57d3b7093259b625672a98b0ff41643175f6cb82/nova/compute/utils.py#L278
  [2]https://github.com/openstack/nova/blob/57d3b7093259b625672a98b0ff41643175f6cb82/nova/notifications/base.py#L382

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1764390/+subscriptions