yahoo-eng-team team mailing list archive

[OpenStack Infra <1764878@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/562062
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=203572a8ae671a64c08cc949b9bbc005e3119d2f
Submitter: Zuul
Branch:    master

commit 203572a8ae671a64c08cc949b9bbc005e3119d2f
Author: Matt Riedemann <mriedem.os@xxxxxxxxx>
Date:   Tue Apr 17 17:55:41 2018 -0400

    Fix docs for confirmResize action
    
    The docs had three things wrong:
    
    1. The server status would be VERIFY_RESIZE, not VERIFY_RESIZED.
    
    2. The RESIZED value is on the OS-EXT-STS:vm_state field, not
       vm_status.
    
    3. The migration record status must be "finished", which is what
       gets set on the migration record in the _finish_resize() method
       in ComputeManager and used in the comptue API.confirm_resize()
       method. "confirming" status is what the API sets the migration
       record to before casting to nova-compute to finish the
       confirmation.
    
    Stepping back, this is too many conditionals for what is really
    needed. So rather than fix all three items individually, this
    change simply fixes the first one and removes the other two since
    the 'status' is based on the 'vm_state' internally, and a non-admin
    user cannot list migrations anyway, and the _finish_resize()
    method sets the migration status *before* the vm_state.
    
    Closes-Bug: #1764878
    
    Change-Id: Ib751686880ee824cf0693a649f47c828f515b471


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1764878

Title:
  api-ref: confirmResize Preconditions doc has some incorrect
  information

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  There are three things wrong here:

  https://developer.openstack.org/api-ref/compute/#confirm-resized-
  server-confirmresize-action

  "You can only confirm the resized server where the status is
  VERIFY_RESIZED, the vm_status is RESIZED, and the migration_status is
  finished or confirming."

  1. The status must be VERIFY_RESIZE.
  2. The vm_state field is RESIZED, not vm_status.
  3. The migration status would be 'finished', not 'confirming' since 'confirming' is the migration status after you initiate the confirmResize status.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1764878/+subscriptions