← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1765742] [NEW] virt_driver.detach_volume rollback calls in attach_volume failures uses wrong method signature

 

Public bug reported:

Seen here:

https://github.com/openstack/nova/blob/64e503d82fe5966cb50b650b3309a7fc36c63cda/nova/virt/block_device.py#L473

and here:

https://github.com/openstack/nova/blob/64e503d82fe5966cb50b650b3309a7fc36c63cda/nova/virt/block_device.py#L570

Those are using the wrong method signature since 'context' was added to
the driver detach_volume method signature in change:

https://review.openstack.org/#/c/549411/

** Affects: nova
     Importance: High
     Assignee: Matt Riedemann (mriedem)
         Status: Triaged

** Affects: nova/queens
     Importance: High
         Status: Confirmed


** Tags: volumes

** Also affects: nova/queens
   Importance: Undecided
       Status: New

** Changed in: nova/queens
       Status: New => Confirmed

** Changed in: nova/queens
   Importance: Undecided => High

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1765742

Title:
  virt_driver.detach_volume rollback calls in attach_volume failures
  uses wrong method signature

Status in OpenStack Compute (nova):
  Triaged
Status in OpenStack Compute (nova) queens series:
  Confirmed

Bug description:
  Seen here:

  https://github.com/openstack/nova/blob/64e503d82fe5966cb50b650b3309a7fc36c63cda/nova/virt/block_device.py#L473

  and here:

  https://github.com/openstack/nova/blob/64e503d82fe5966cb50b650b3309a7fc36c63cda/nova/virt/block_device.py#L570

  Those are using the wrong method signature since 'context' was added
  to the driver detach_volume method signature in change:

  https://review.openstack.org/#/c/549411/

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1765742/+subscriptions


Follow ups