yahoo-eng-team team mailing list archive

[Takashi NATSUME <natsume.takashi@xxxxxxxxxxxxx>]

Public bug reported:

The 'detach_volume' method is called in nova/virt/block_device.py.

virt_driver.detach_volume(connection_info, instance,
self['mount_device'], encryption=encryption)

https://github.com/openstack/nova/blob/0ef3c685b9d2e0049f38fcf1a268870e69a5b9cf/nova/virt/block_device.py#L473-L476

But the signature is as follows:

detach_volume(self, context, connection_info, instance, mountpoint,
encryption=None)

The context is missing.

https://github.com/openstack/nova/blob/0ef3c685b9d2e0049f38fcf1a268870e69a5b9cf/nova/virt/driver.py#L469-L470

nova master (commit 0ef3c685b9d2e0049f38fcf1a268870e69a5b9cf)

** Affects: nova
     Importance: Undecided
     Assignee: Takashi NATSUME (natsume-takashi)
         Status: In Progress

** Changed in: nova
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1768965

Title:
  Wrong arguments for 'detach_volume' of virt driver

Status in OpenStack Compute (nova):
  In Progress

Bug description:
  The 'detach_volume' method is called in nova/virt/block_device.py.

  virt_driver.detach_volume(connection_info, instance,
  self['mount_device'], encryption=encryption)

  https://github.com/openstack/nova/blob/0ef3c685b9d2e0049f38fcf1a268870e69a5b9cf/nova/virt/block_device.py#L473-L476

  But the signature is as follows:

  detach_volume(self, context, connection_info, instance, mountpoint,
  encryption=None)

  The context is missing.

  https://github.com/openstack/nova/blob/0ef3c685b9d2e0049f38fcf1a268870e69a5b9cf/nova/virt/driver.py#L469-L470

  nova master (commit 0ef3c685b9d2e0049f38fcf1a268870e69a5b9cf)

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1768965/+subscriptions