← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1769704] Re: VPN gate broken by change to _setUpExtension in neutron.tests.unit.extensions.base

 

Reviewed:  https://review.openstack.org/566673
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e177aafcedef27782bba5b34e7880cac56e9c773
Submitter: Zuul
Branch:    master

commit e177aafcedef27782bba5b34e7880cac56e9c773
Author: Miguel Lavalle <miguel.lavalle@xxxxxxxxxx>
Date:   Mon May 7 11:17:38 2018 -0500

    Fix _setUpExtension shim
    
    [1] recently converted _setUpExtension in [2] into a shim for a new
    setup_extension method where an unused argument (resource_attribute_map)
    is removed. In the process, a bug was introduced when calling the
    new method by calling it with predefined values. This patch fixes it.
    
    [1] Ia59fc1978228f9982d3ee447ebcfcb712eebbdb7
    [2] neutron.tests.unit.extensions.base
    
    Closes-Bug: #1769704
    
    Change-Id: I39fb64d76809f49526e557e39cb07dfd9abdf9cb


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1769704

Title:
  VPN gate broken by change to _setUpExtension in
  neutron.tests.unit.extensions.base

Status in neutron:
  Fix Released

Bug description:
  Patchset https://review.openstack.org/#/c/561305 recently converted
  _setUpExtension in  neutron.tests.unit.extensions.base into a shim for
  a new setup_extension method where an unused argument
  (resource_attribute_map) is removed. In the process, a bug was
  introduced when calling the new method by calling it with predefined
  values. This is breaking at least some of the VPNaaS unit tests. Other
  sub-projects might be affected as well

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1769704/+subscriptions


References