← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1763907] Re: allocation candidates member_of gets all the shared providers

 

Reviewed:  https://review.openstack.org/561400
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=0bb490e73fdb0914c01109565f59569dd1c73439
Submitter: Zuul
Branch:    master

commit 0bb490e73fdb0914c01109565f59569dd1c73439
Author: Tetsuro Nakamura <nakamura.tetsuro@xxxxxxxxxxxxx>
Date:   Sat Apr 14 19:24:09 2018 +0900

    Fix member_of with sharing providers
    
    When the `member_of` parameter was present, non-sharing providers
    incorrectly associated sharing providers with other sharing providers
    with no direct connection to non-sharing providers involved in other
    parts of the request.
    
    This patch fixes the bug by adding the aggregate check in SQL
    query when getting sharing providers.
    
    Change-Id: I566cc5458175f8e3075be6967e5f6d91847ce198
    Closes-Bug: #1763907
    Blueprint: alloc-candidates-member-of


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1763907

Title:
  allocation candidates member_of gets all the shared providers

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  When the `member_of` parameter is present, only non shared providers
  in the specified aggregation are picked, but the non shared provider
  brings shared providers from out of the specified aggregation.

  For example, with the following set up,

  ```
                 CN1 (VCPU)                   CN2 (VCPU)
                / agg3         \ agg1        / agg1         \ agg2
       SS3 (DISK_GB)      SS1 (DISK_GB)          SS2 (DISK_GB)
  ```

  When you request allocation candidates in "agg3" using `member_of` parameter,
  expected is to get one allocation request of the combination of (CN1+SS3),
  but actual is to get two allocation request, (CN1+SS3) and (CN1+SS1).

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1763907/+subscriptions


References