yahoo-eng-team team mailing list archive

[OpenStack Infra <1760843@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/559676
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=b6da8a1b8976579e4bf4025b58a69a9be539c847
Submitter: Zuul
Branch:    master

commit b6da8a1b8976579e4bf4025b58a69a9be539c847
Author: wangxiyuan <wangxiyuan@xxxxxxxxxx>
Date:   Mon Apr 9 17:25:14 2018 +0800

    Update IdP sql model
    
    Base on the database schema, the domain_id column in identity_provider
    is not unique and has the ForeignKey for project.id. But the IdP sql
    model is different. It marks the domain_id is unique and the ForeignKey
    is lost.
    
    This patch removes the unique restriction and adds the FK back, ultimately
    making the relationship between domains and identity provider 1:many.
    
    Change-Id: I13ecb0ab0434f5614f31d151e708f299cf8e8adb
    Partial-bug: #1760843


** Changed in: keystone
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1760843

Title:
  Identity Provider domain is not unique

Status in OpenStack Identity (keystone):
  Fix Released

Bug description:
  Backing to the patch https://review.openstack.org/#/c/399684/ when the
  domain_id is added  for Idp, I assume that the domain_id is designed
  for unique?

  The domain_id in Idp model is unique:
  https://github.com/openstack/keystone/blob/master/keystone/federation/backends/sql.py#L58

  But the db migration is not:
  https://github.com/openstack/keystone/blob/master/keystone/common/sql/expand_repo/versions/012_expand_add_domain_id_to_idp.py#L55-L56

  They are not in consistence. Since I don't know the origin purpose for
  the change, I'm not very sure which is correct but I prefer the first
  one.

  What's more, our unit test use resource models to init db so that it's
  unique in our unit test sqlite db. It's not in consistence as well
  with the real usage.

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1760843/+subscriptions