yahoo-eng-team team mailing list archive

[OpenStack Infra <1774556@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/571610
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=39a9617f4a2710ef5a6c6032774af163046a82dc
Submitter: Zuul
Branch:    master

commit 39a9617f4a2710ef5a6c6032774af163046a82dc
Author: Yikun Jiang <yikunkero@xxxxxxxxx>
Date:   Fri Jun 1 10:14:12 2018 +0800

    Fix invalid raise in test_compute_mgr
    
    This patch replaces that invalid raise with a proper exception
    raise.
    
    TrivialFix
    
    See same related fix in c52d34f1b46f88ae2786cfb873f9b12a1a01b629
    
    Change-Id: Ie25c4d78715d1d02a22d051a898a55bc5eea4932
    Closes-Bug: #1774556


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1774556

Title:
  Invalid raise in test_compute_mgr

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  The test code in [1][2] uses `raise` statement without any parameter.
  It is not a valid python construct if used outside of an `expect`
  block.

  The test does not fail on this as this codepath never executed.

  
  Also see the reference bug[3].

  [1]
  https://github.com/openstack/nova/blob/a7994ec3559cede764a6ff04f7fddc5a5b6d63ea/nova/tests/unit/compute/test_compute_mgr.py#L5851

  [2]
  https://github.com/openstack/nova/blob/a7994ec3559cede764a6ff04f7fddc5a5b6d63ea/nova/tests/unit/compute/test_compute_mgr.py#L5872

  [3]https://bugs.launchpad.net/nova/+bug/1754409

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1774556/+subscriptions