yahoo-eng-team team mailing list archive

[OpenStack Infra <1767829@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/572295
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=11b41d73b48d46b7725bb97d4b85158d8bc2acfb
Submitter: Zuul
Branch:    master

commit 11b41d73b48d46b7725bb97d4b85158d8bc2acfb
Author: Slawek Kaplonski <skaplons@xxxxxxxxxx>
Date:   Tue Jun 5 10:05:58 2018 +0200

    [Fullstack] Wait for SG to be applied by L2 agent
    
    In fullstack test_securitygroup there were used simple
    net_helpers.assert_ping() and assert_not_ping() functions
    which tries to ping IP address 3 times with some short timeout
    and test fails if result of ping will not be as expected.
    
    Unfortunately sometimes in fullstack tests it might be not enough
    if test is creating new SG or SG rule or apply SG to port and
    just after that checks connection because L2 agent don't have
    enough time to apply all rules on "host".
    This patch changes it to use block_until_ping() and
    block_until_no_ping() methods from FakeMachine fixture.
    It will also check if ping is possible/not possible but
    will try to check it for 1 minute before fails.
    
    Similar change is also done for methods which checks TCP
    connectivity using netcat helper class. It now uses
    common_utils.wait_until_true() helper function instead of
    fail immediatelly.
    
    Change-Id: I9e523d803e3c49d5d090ae5b9d36d43ce7311535
    Closes-Bug: #1774006
    Closes-Bug: #1767829


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1767829

Title:
  Fullstack test_securitygroup.TestSecurityGroupsSameNetwork fails often
  after SG rule delete

Status in neutron:
  Fix Released

Bug description:
  Fullstack test_securitygroup.TestSecurityGroupsSameNetwork is failing
  quite often like for example at:
  http://logs.openstack.org/12/470912/38/check/neutron-
  fullstack/ba16b38/logs/testr_results.html.gz

  It happens quite lot recently (48 times in last 7 days):
  http://logstash.openstack.org/#dashboard/file/logstash.json?query=build_name%3A%5C
  %22neutron-
  fullstack%5C%22%20AND%20message%3A%5C%22line%20264%2C%20in%20test_securitygroup%5C%22

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1767829/+subscriptions