yahoo-eng-team team mailing list archive

[OpenStack Infra <1776668@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/575117
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1a5a3a9bc8409349ab817b4858ee54bf2a036dab
Submitter: Zuul
Branch:    master

commit 1a5a3a9bc8409349ab817b4858ee54bf2a036dab
Author: Chris Dent <cdent@xxxxxxxxxxxxx>
Date:   Wed Jun 13 14:38:23 2018 +0100

    [placement] Add status and links fields to version document at /
    
    According to the spec [1] the version discovery doc must have a status
    and links for each version. For the primary version the status value
    should be 'CURRENT'. For placement the version discovery doc and "self"
    are the same thing, so the provided "self" href looks redundant, but it
    makes keystoneauth1 happy when doing version discovery.
    
    In placement, since there is only one version at the moment, set status
    to CURRENT.
    
    Add a gabbi test that verifies the presence of both fields and values.
    
    Without these fields, use of placement with a client that follows the
    documented version discovery process will fail to work.
    
    As the version doc is not considered microversioned[2] and in any case
    this is making version discovery work where it didn't before, this is
    not a candidate for a microversion and can be backported to the
    beginning of placement's history if we like.
    
    I've updated the api-ref docs. In the process I made the max
    microversion in the sample discovery doc a bit more realistic and
    in alignment with these modern times.
    
    [1] http://specs.openstack.org/openstack/api-wg/guidelines/microversion_specification.html#version-discovery
    [2] http://eavesdrop.openstack.org/irclogs/%23openstack-sdks/%23openstack-sdks.2018-06-13.log.html#t2018-06-13T13:40:12
    
    Change-Id: Ie602ab1768efbf103563d8f6b9d28965fc81021a
    Closes-Bug: #1776668


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1776668

Title:
  the placement version discovery doc at / does't have a status field,
  it should

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Version discovery docs are supposed to have a status field:
  http://specs.openstack.org/openstack/api-
  wg/guidelines/microversion_specification.html#version-discovery

  Placement's does not. This was probably an oversight resulting from
  casual attention to detail since placement only has one version.

  This is easily fixable and easily backportable, so I'll get on that.

  This is causing problems for at least mnaser when trying to write his
  own client code.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1776668/+subscriptions