yahoo-eng-team team mailing list archive

[OpenStack Infra <1776255@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/574370
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e356345261737162aab90bf7338d931d64ae524e
Submitter: Zuul
Branch:    master

commit e356345261737162aab90bf7338d931d64ae524e
Author: Kailun Qin <kailun.qin@xxxxxxxxx>
Date:   Tue Jun 12 10:22:32 2018 +0800

    Fix DVR scheduling checks wrong profile for host
    
    When DVR scheduling in live-migration, the current implementation in DVR
    serviceable ports checking on host performs a "contains" operation of
    sub-string match which checks the wrong port binding profile for host
    (i.e. compute-1 will also match compute-10).
    
    Add quotes to force an exact match of the host name in the port binding
    profile dictionary to address this issue.
    
    Closes-Bug: #1776255
    Change-Id: I0d2bd9b9ff0aa58a7cce1b8da2a5f21ac6b38c57
    Signed-off-by: Kailun Qin <kailun.qin@xxxxxxxxx>


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1776255

Title:
  DVR scheduling checks wrong port binding profile for host in live-
  migration

Status in neutron:
  Fix Released

Bug description:
  When live-migrating, active l3 agents on compute nodes will request a
  router sync against DVR routers impacted by the migration. This will
  check for existence of dvr serviceable ports on host to further filter
  the router applicable to it. However, the current implementation
  performs a "contains" operation on the port binding profile for host
  which will produce a LIKE expression that tests against a match for
  the middle of a string value: column LIKE '%' || <host> || '%' [1].
  This leads to a wrong filtering due to the sub-string match (i.e.
  compute-1 will match compute-10).

  [1]
  http://docs.sqlalchemy.org/en/latest/orm/internals.html?highlight=contains#sqlalchemy.orm.attributes.QueryableAttribute.contains

  Example binding profile (dict) for host:
  {
    "binding:profile": {"migrating_to": "compute-1"}
  }

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1776255/+subscriptions