← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1774208] Re: osprofiler config options don't show up in nova configuration reference

 

Reviewed:  https://review.openstack.org/571225
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=dee92e6876cec8d3db23d54cccd7a1dec851a593
Submitter: Zuul
Branch:    master

commit dee92e6876cec8d3db23d54cccd7a1dec851a593
Author: Matt Riedemann <mriedem.os@xxxxxxxxx>
Date:   Wed May 30 11:16:45 2018 -0400

    Add osprofiler config options to generated reference
    
    osprofiler is optional, but if it's installed we'll
    load up the configuration options from the library,
    but they weren't in the generated config sample so
    people would have to find the osprofiler docs, or
    worse the code, to figure out how to configure it.
    
    This simply adds the osprofiler config options to the
    nova config sample, which will also show up in the
    config reference docs.
    
    Change-Id: I28d35165ed77487cd49d560fb1eda4f1d640734e
    Closes-Bug: #1774208


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1774208

Title:
  osprofiler config options don't show up in nova configuration
  reference

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Looking at the nova configuration reference and sample:

  https://docs.openstack.org/nova/latest/configuration/config.html

  The osprofiler options aren't included:

  https://github.com/openstack/osprofiler/blob/master/osprofiler/opts.py

  osprofiler is optional but if available we load the config options:

  https://github.com/openstack/nova/blob/465051809c1f09417207136e2ac8615838262c1a/nova/config.py#L46

  So we should probably include those in the configuration reference for
  nova. For example, we also include config options for the vmware
  driver which is optional, and oslo.vmware is in test-requirements.txt
  like osprofiler.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1774208/+subscriptions


References