yahoo-eng-team team mailing list archive

[OpenStack Infra <1768077@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/566947
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=d501960d7e8474927ebd6d6abc52350a0f23275a
Submitter: Zuul
Branch:    master

commit d501960d7e8474927ebd6d6abc52350a0f23275a
Author: Brian Rosmaita <rosmaita.fossdev@xxxxxxxxx>
Date:   Tue May 8 12:54:24 2018 -0400

    Refactor wait_for_scrubber_shutdown function
    
    The wait_for_scrubber_shutdown function catches AssertionErrors
    and retries.  Refactor it so that it only retries for a specific
    error (namely, when glance scrubber is running in daemon mode when
    the test is being executed) by changing the function so that it
    returns values instead of relying on test assertions in the
    function passed to it.  Also refactor the tests that call
    wait_for_scrubber_shutdown so that they check the returned results
    instead of using assertions in the function they pass to
    wait_for_scrubber_shutdown.
    
    This is a follow-up to https://review.openstack.org/#/c/566681/
    
    Change-Id: I7108179e0d96e09638ff783b029a8216f0938c3b
    Closes-bug: #1768077


** Changed in: glance
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1768077

Title:
  intermittent functional test failures related to scrubber

Status in Glance:
  Fix Released

Bug description:
  I'm not completely sure that the scrubber tests are the culprit, but
  they seem to be a common factor.

  We're seeing different failures in the functional (py27) tests and the
  functional-py35 tests.

  (1) py27
  "AssertionError: unexpected error occurred in glance-scrubber" happening in wait_for_scrubber_shutdown

  Observed on:
  - https://review.openstack.org/#/c/564077
  - https://review.openstack.org/#/c/564883

  See http://paste.openstack.org/show/720153/ (not sure how long the
  logs will be kept).

  
  (2) py35
  This one is trickier because the failure is causing the subunit parser to crash during test runs, so there are several tests failing, but it looks like the scrubber tests are the constant factor.

  Observed on:
  - https://review.openstack.org/#/c/564649/
  - https://review.openstack.org/#/c/564077/
  - https://review.openstack.org/#/c/554174/

  See http://paste.openstack.org/show/720155/ for list of tests failing when this happens.
  See http://eavesdrop.openstack.org/irclogs/%23openstack-infra/%23openstack-infra.2018-04-27.log.html#t2018-04-27T17:20:55 for discussion with clarkb about these failures.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1768077/+subscriptions