← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1777671] [NEW] Incorrect use of translation _()

 

Public bug reported:

Keystone uses translated strings both in logging an exceptions. This is
incorrect.

All strings that are passed to logging should remain un-translated. The
solution is to duplicate the string and pass the untranslated (not
wrapped with `_()`) to the logger while passing the translated `_()`
wrapped string to the exception.

Relevant Discussion: http://eavesdrop.openstack.org/irclogs
/%23openstack-oslo/%23openstack-
oslo.2018-06-18.log.html#t2018-06-18T22:03:19

** Affects: keystone
     Importance: Medium
         Status: Triaged


** Tags: low-hanging-fruit office-hours

** Changed in: keystone
       Status: New => Triaged

** Changed in: keystone
   Importance: Undecided => Medium

** Changed in: keystone
    Milestone: None => rocky-3

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1777671

Title:
  Incorrect use of translation _()

Status in OpenStack Identity (keystone):
  Triaged

Bug description:
  Keystone uses translated strings both in logging an exceptions. This
  is incorrect.

  All strings that are passed to logging should remain un-translated.
  The solution is to duplicate the string and pass the untranslated (not
  wrapped with `_()`) to the logger while passing the translated `_()`
  wrapped string to the exception.

  Relevant Discussion: http://eavesdrop.openstack.org/irclogs
  /%23openstack-oslo/%23openstack-
  oslo.2018-06-18.log.html#t2018-06-18T22:03:19

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1777671/+subscriptions


Follow ups