← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1461251] Re: Stop using deprecated oslo_utils.timeutils.isotime

 

Reviewed:  https://review.openstack.org/579145
Committed: https://git.openstack.org/cgit/openstack/ec2-api/commit/?id=c65cb663de5d1cfb239bbf32610f0f7a71c7e170
Submitter: Zuul
Branch:    master

commit c65cb663de5d1cfb239bbf32610f0f7a71c7e170
Author: chenghuiyu <yuchenghui@xxxxxxxxxxxx>
Date:   Mon Sep 11 10:48:48 2017 +0800

    Fix usage of isotime
    
    The commit I34b12b96de3ea21beaf935ed8a9f6bae2fe0d0bc and
    Ib384ae8130dcc6cbd47a837d11ca171ce02ef29e introduced the
    deprecated oslo_utils.timeutils.isotime() is deprecated
    as of 1.6.
    
    The deprecation message says to use the datetime.datetime.isoformat()
    instead, but the format of the string generated by isoformat isn't
    the same as the format of the string generated by isotime. The string
    is used in tokens and other public APIs and we can't change it
    without potentially breaking clients.
    
    So the workaround is to copy the current implementation from
    oslo_utils.timeutils.isotime() to ec2api.api.ec2utils.
    
    For more informations:
    https://docs.openstack.org/oslo.utils/latest/reference/timeutils.html
    
    Change-Id: Id62fb53264b04a7ea6ae3035a129353c5cfa040a
    Closes-Bug: #1461251


** Changed in: ec2-api
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1461251

Title:
  Stop using deprecated oslo_utils.timeutils.isotime

Status in cloudkitty:
  Fix Released
Status in ec2-api:
  Fix Released
Status in gce-api:
  In Progress
Status in OpenStack Identity (keystone):
  Fix Released
Status in oslo.utils:
  In Progress
Status in python-keystoneclient:
  Fix Released

Bug description:
  oslo_utils.timeutils.isotime() is deprecated as of 1.6 so we need to
  stop using it.

  This breaks unit tests in keystone since we've got a check for calling
  deprecated functions.

To manage notifications about this bug go to:
https://bugs.launchpad.net/cloudkitty/+bug/1461251/+subscriptions


References