← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1779626] Re: MTU setting feature conflicts with minimum Qemu version

 

Reviewed:  https://review.openstack.org/579611
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=e2d7189f4ff7e4a2697256cf3f695327e1d71db2
Submitter: Zuul
Branch:    master

commit e2d7189f4ff7e4a2697256cf3f695327e1d71db2
Author: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@xxxxxxxxxx>
Date:   Mon Jul 2 17:42:05 2018 +0200

    libvirt: add qemu version check when configuring mtu for network
    
    This adds a QEMU check when configuring MTU for ethernet and bridge
    interface types. When creating and configuring tap devices, libvirt is
    setting MTU but also configures the virtio-net devices to let it
    discovers the MTU used. This QEMU 'host_mtu' option is supported by
    QEMU version 2.9 and more.
    
    Closes-Bug: 1779626
    Change-Id: I55cf259c715ba129fa8479d1e8a0d11ec15aaa43
    Signed-off-by: Sahid Orentino Ferdjaoui <sahid.ferdjaoui@xxxxxxxxxx>


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1779626

Title:
  MTU setting feature conflicts with minimum Qemu version

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Afaics Nova breaks with Qemu versions newer than the minimum required
  version.

  The change at [1] added support for setting MTU size in the libvirt settings of guests. This code checks for a minimum libvirt version 3.3.0 [2] but not for a required Qemu version.
  The Nova minimum required Qemu version is 2.5 currently according to [3] (which is the latest release available with Ubuntu Xenial 16.04).
  Afaics Qemu added support with release 2.9 [4] which means versions 2.5 to 2.8 of Qemu will break despite being listed as supported iiuc.
  This issue broke our CIs. For verification i checked the master commit [5] which merged prior to [1] which tested ok with our CI.

  The fix probably is to simply add a check for the minimum required
  Qemu version beside the minimum required libvirt version.

  
  [1] https://review.openstack.org/#/c/553072/
  [2] https://github.com/openstack/nova/blob/4ea64cad3fcc4897690bfb2c02d2b06d65db4dcf/nova/virt/libvirt/vif.py#L55
  [3] https://wiki.openstack.org/wiki/LibvirtDistroSupportMatrix
  [4] https://wiki.qemu.org/ChangeLog/2.9)
  [5] https://review.openstack.org/#/c/570656/

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1779626/+subscriptions


References