← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1780373] Related fix merged to nova (master)

 

Reviewed:  https://review.openstack.org/580755
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=f9874e059df50dc81803fcfdfd1045cc09624894
Submitter: Zuul
Branch:    master

commit f9874e059df50dc81803fcfdfd1045cc09624894
Author: Matt Riedemann <mriedem.os@xxxxxxxxx>
Date:   Fri Jul 6 16:10:48 2018 -0400

    Add functional regressions tests for server_group_members OverQuota
    
    Since we started counting quotas in Pike, it is possible to bypass
    the server_group_members qouta check if either creating multiple
    servers in a single request or creating one server each in multiple
    concurrent requests. This is because the server_group_members
    count is based on existing server group members in the cell database
    and those group members (instances) don't get created in a cell until
    we get to conductor and after the scheduler picks a host. In other
    words, the server_group_members quota check in the API does not account
    for build requests.
    
    Change-Id: Icb268ca2f792bfcefd152ba4c6aa13270d9a7900
    Related-Bug: #1780373


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1780373

Title:
  server_group_members quota check failure with multi-create

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) pike series:
  In Progress
Status in OpenStack Compute (nova) queens series:
  In Progress

Bug description:
  Circumstance:
  When multi-creating a quota-exceeding number of instances in a server group, it will pass server_group_members quota check.

  Actual result:
  Servers successfully created.

  Expected result:
  Raising QuotaExceeded API exception.

  Reproduce steps (Queen):
  1 nova server-group-create sg affinity (policy shouldn't matter)
  2 set in nova.conf server_group_members=2 (so we don't need to create too many servers to test)
  3 nova boot --flavor flavor --net net-name=netname --image image --max-count 3 server-name
  Then we will see all 3 servers created successfully, violating server_group_members quota policy.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1780373/+subscriptions


References