← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1781179] Re: [RFE] Send "update" instead of "remove" notification for dvr rescheduling

 

Reviewed:  https://review.openstack.org/581658
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8b16b53b5b54b2ad8521b6c6c22660fab30e1b0d
Submitter: Zuul
Branch:    master

commit 8b16b53b5b54b2ad8521b6c6c22660fab30e1b0d
Author: Kailun Qin <kailun.qin@xxxxxxxxx>
Date:   Thu Jul 12 03:18:23 2018 +0800

    Send update instead of remove for DVR reschedule
    
    The current "agent remove-add" method to reschedule a router is not
    friendly for DVR. In DVR cases, the old agent may still need to keep the
    router in a non-master role to service any VM ports that exit on that
    host while the new agent handles the master role of the router.
    
    This patch proposes to send "update" instead of "remove" notification
    for DVR rescheduling, which aligns with the retain_router check in
    remove_router_from_l3_agent as well.
    
    Closes-Bug: #1781179
    Change-Id: I23431f9f46f72e6bce91f3d1fb0ed328d55930fb


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1781179

Title:
  [RFE] Send "update" instead of "remove" notification for dvr
  rescheduling

Status in neutron:
  Fix Released

Bug description:
  Currently, the normal method to reschedule a router is to send a
  "removed" notification to the old l3 agent followed by an "added"
  notification targeting the new agent.

  However for DVR, this is too harsh as the old agent may still need to
  keep the router in a non-master role to service any VM ports that
  exist on that host while the new agent handles the master role of the
  router (i.e., the centralized components of the router). Besides, the
  current implementation in remove_router_from_l3_agent also verifies if
  there are DVR serviceable ports owned by this agent. If so, then the
  router should be retained.

  The same mechanism should be aligned and applied to dvr rescheduling
  as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1781179/+subscriptions


References