← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1780727] Re: Handle HostMappingNotFound when deleting a service

 

Reviewed:  https://review.openstack.org/582674
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ee6e0c1e7eb861e56915c5b6c60a214b75240366
Submitter: Zuul
Branch:    master

commit ee6e0c1e7eb861e56915c5b6c60a214b75240366
Author: Matt Riedemann <mriedem.os@xxxxxxxxx>
Date:   Fri Jul 13 15:42:03 2018 -0400

    Handle HostMappingNotFound when deleting a compute service
    
    If the compute service we're deleting has never been
    discovered (mapped to a cell using discover_hosts) or the
    host mapping was already deleted, we need to handle the
    HostMappingNotFound error when deleting a compute service
    so that we (1) don't 500 out of the API and (2) continue to
    delete the compute service.
    
    Change-Id: I0d7644db3537a67b94e75972b3c4fce25a623763
    Closes-Bug: #1780727


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1780727

Title:
  Handle HostMappingNotFound when deleting a service

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) pike series:
  Confirmed
Status in OpenStack Compute (nova) queens series:
  Confirmed

Bug description:
  While deleting a service, we also try to delete the HostMapping before
  it here:
  https://github.com/openstack/nova/blob/fcf406003bcde2b60a515f694f2640e27a9d65fd/nova/api/openstack/compute/services.py#L243
  . However there could be a situation where we do not find the
  HostMapping (for instance when we run nova-manage cell_v2 delete_host
  before nova service-delete). This needs to be handled in the try catch
  block and if we do not find the host_mapping, we just need to proceed
  to deleting the service as opposed to the current behaviour where it
  gives a 500.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1780727/+subscriptions


References