← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1782386] [NEW] compute node local_gb_used does not include swap disks

 

Public bug reported:

The ComputeNode.local_gb_used value is set in the
ResourceTracker._update_usage() method:

https://github.com/openstack/nova/blob/eb4f65a7951e921b1cd8d05713e144e72f2f254f/nova/compute/resource_tracker.py#L934

Based on:

1. root_gb in the flavor
2. any disk overhead from the virt driver
3. ephemeral_gb in the flavor

It was added in this change in Grizzly:
https://review.openstack.org/#/c/13182/

However, the RT does not take into account swap disk, which was fixed in
the DiskFilter in Icehouse:

https://review.openstack.org/#/c/51323/

But is still missing the swap (MB) calculation for local_gb_used in the
ResourceTracker (after all these years).

Given how latent this bug is, it's low priority to fix it, and really
long-term we should probably change the ResourceTracker to report usage
from the placement API since that correctly accounts for
root_gb/ephemeral_gb/swap (mb) when posting DISK_GB allocations to
placement.

** Affects: nova
     Importance: Low
         Status: Triaged


** Tags: compute resource-tracker

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1782386

Title:
  compute node local_gb_used does not include swap disks

Status in OpenStack Compute (nova):
  Triaged

Bug description:
  The ComputeNode.local_gb_used value is set in the
  ResourceTracker._update_usage() method:

  https://github.com/openstack/nova/blob/eb4f65a7951e921b1cd8d05713e144e72f2f254f/nova/compute/resource_tracker.py#L934

  Based on:

  1. root_gb in the flavor
  2. any disk overhead from the virt driver
  3. ephemeral_gb in the flavor

  It was added in this change in Grizzly:
  https://review.openstack.org/#/c/13182/

  However, the RT does not take into account swap disk, which was fixed
  in the DiskFilter in Icehouse:

  https://review.openstack.org/#/c/51323/

  But is still missing the swap (MB) calculation for local_gb_used in
  the ResourceTracker (after all these years).

  Given how latent this bug is, it's low priority to fix it, and really
  long-term we should probably change the ResourceTracker to report
  usage from the placement API since that correctly accounts for
  root_gb/ephemeral_gb/swap (mb) when posting DISK_GB allocations to
  placement.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1782386/+subscriptions


Follow ups