← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1780094] Re: The transition of a router from distributed to centralized may mistakenly get HA enabled

 

Reviewed:  https://review.openstack.org/580173
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=886e24155358afe7ad167ba1602d3939d68c3d5f
Submitter: Zuul
Branch:    master

commit 886e24155358afe7ad167ba1602d3939d68c3d5f
Author: Kailun Qin <kailun.qin@xxxxxxxxx>
Date:   Thu Jul 5 07:17:31 2018 +0800

    Fix attribute mismatch in router provider update
    
    The transition of a router from distributed to centralized may
    mistakenley get its 'ha' attribute updated at the same time. The
    side-effect is that the router may become HA enabled unexpectedly.
    
    This patch fixed the mismatched attribute in _update_router_provider
    method which addressed the issue cited above.
    
    Closes-Bug: #1780094
    Change-Id: Ib00de137692979229d1b7ba033ecff04e9cc9db0


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1780094

Title:
  The transition of a router from distributed to centralized may
  mistakenly get HA enabled

Status in neutron:
  Fix Released

Bug description:
  The transition of a router's 'distributed' attribute from True to
  False may mistakenly get its 'ha' attribute updated at the same time.
  The side-effect is that the router may become HA enabled unexpectedly,
  which does not respect the user's request.

  Steps to reproduce:
  1. neutron router-create test
  2. neutron router-show test  # HA=false
  3. neutron router-update test --admin_state_up false
  4. neutron router-update test --distributed true
  5. neutron router-update test --admin_state_up true
  6. neutron router-show test  # HA=false => expected
  7. neutron router-update test --admin_state_up false
  8. neutron router-update test --distributed false
  9. neutron router-update test --admin_state_up true
  10. neutron router-show test  # HA=true => unexpected

  For further detailed information, please kindly refer to the failed
  CLI log attached.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1780094/+subscriptions


References