← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1783095] Re: Fullstack tests fail on python3 parsing MTU configuration

 

Reviewed:  https://review.openstack.org/584431
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3d06c63e74a8ded495a064349951097f33d8fb49
Submitter: Zuul
Branch:    master

commit 3d06c63e74a8ded495a064349951097f33d8fb49
Author: Bernard Cafarelli <bcafarel@xxxxxxxxxx>
Date:   Fri Jul 20 17:47:00 2018 +0200

    [Fullstack] Use string for global_physnet_mtu config option
    
    This was added in Ia838d2a661c5098f90b58b2cb31557f2ebf78868 and breaks
    config parser with python3
    
    Closes-Bug: #1783095
    Change-Id: I1cd054edb32e7ccf3bd3a356ed535a4a6003a9a1


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1783095

Title:
  Fullstack tests fail on python3 parsing MTU configuration

Status in neutron:
  Fix Released

Bug description:
  On python3 gate master, fullstack tests fail to load configuration
  since Ia838d2a661c5098f90b58b2cb31557f2ebf78868 was merged

  Sample failure:
  ft1.1: neutron.tests.fullstack.test_connectivity.TestConnectivitySameNetworkNoDhcp.test_connectivity(Open vSwitch agent)_StringException: traceback-1: {{{
  Traceback (most recent call last):
    File "/opt/stack/new/neutron/.tox/dsvm-fullstack-python35/lib/python3.5/site-packages/fixtures/fixture.py", line 197, in setUp
      self._setUp()
    File "/opt/stack/new/neutron/neutron/tests/fullstack/resources/config.py", line 103, in _setUp
      super(NeutronConfigFixture, self)._setUp()
    File "/opt/stack/new/neutron/neutron/tests/common/config_fixtures.py", line 55, in _setUp
      self.write_config_to_configfile()
    File "/opt/stack/new/neutron/neutron/tests/common/config_fixtures.py", line 58, in write_config_to_configfile
      config_parser = self.dict_to_config_parser(self.config)
    File "/opt/stack/new/neutron/neutron/tests/common/config_fixtures.py", line 71, in dict_to_config_parser
      config_parser.set(section, option, value)
    File "/usr/lib/python3.5/configparser.py", line 1189, in set
      self._validate_value_types(option=option, value=value)
    File "/usr/lib/python3.5/configparser.py", line 1174, in _validate_value_types
      raise TypeError("option values must be strings")
  TypeError: option values must be strings

  During handling of the above exception, another exception occurred:

  Traceback (most recent call last):
    File "/opt/stack/new/neutron/.tox/dsvm-fullstack-python35/lib/python3.5/site-packages/fixtures/fixture.py", line 208, in setUp
      raise SetupError(details)
  fixtures.fixture.SetupError: {}
  }}}

  traceback-2: {{{
  Traceback (most recent call last):
    File "/opt/stack/new/neutron/.tox/dsvm-fullstack-python35/lib/python3.5/site-packages/fixtures/fixture.py", line 197, in setUp
      self._setUp()
    File "/opt/stack/new/neutron/neutron/tests/fullstack/resources/config.py", line 103, in _setUp
      super(NeutronConfigFixture, self)._setUp()
    File "/opt/stack/new/neutron/neutron/tests/common/config_fixtures.py", line 55, in _setUp
      self.write_config_to_configfile()
    File "/opt/stack/new/neutron/neutron/tests/common/config_fixtures.py", line 58, in write_config_to_configfile
      config_parser = self.dict_to_config_parser(self.config)
    File "/opt/stack/new/neutron/neutron/tests/common/config_fixtures.py", line 71, in dict_to_config_parser
      config_parser.set(section, option, value)
    File "/usr/lib/python3.5/configparser.py", line 1189, in set
      self._validate_value_types(option=option, value=value)
    File "/usr/lib/python3.5/configparser.py", line 1174, in _validate_value_types
      raise TypeError("option values must be strings")
  TypeError: option values must be strings

  During handling of the above exception, another exception occurred:

  Traceback (most recent call last):
    File "/opt/stack/new/neutron/.tox/dsvm-fullstack-python35/lib/python3.5/site-packages/fixtures/fixture.py", line 197, in setUp
      self._setUp()
    File "/opt/stack/new/neutron/neutron/tests/fullstack/resources/environment.py", line 380, in _setUp
      cfg.CONF.database.connection, self.rabbitmq_environment))
    File "/opt/stack/new/neutron/.tox/dsvm-fullstack-python35/lib/python3.5/site-packages/fixtures/fixture.py", line 257, in useFixture
      fixture.setUp()
    File "/opt/stack/new/neutron/.tox/dsvm-fullstack-python35/lib/python3.5/site-packages/fixtures/fixture.py", line 212, in setUp
      raise MultipleExceptions(*errors)
  testtools.runtest.MultipleExceptions: ((<class 'TypeError'>, TypeError('option values must be strings',), <traceback object at 0x7f74e3b229c8>), (<class 'fixtures.fixture.SetupError'>, SetupError({},), <traceback object at 0x7f74e3ae9048>))

  During handling of the above exception, another exception occurred:

  Traceback (most recent call last):
    File "/opt/stack/new/neutron/.tox/dsvm-fullstack-python35/lib/python3.5/site-packages/fixtures/fixture.py", line 208, in setUp
      raise SetupError(details)
  fixtures.fixture.SetupError: {}
  }}}

  Traceback (most recent call last):
    File "/opt/stack/new/neutron/.tox/dsvm-fullstack-python35/lib/python3.5/site-packages/fixtures/fixture.py", line 197, in setUp
      self._setUp()
    File "/opt/stack/new/neutron/neutron/tests/fullstack/resources/config.py", line 103, in _setUp
      super(NeutronConfigFixture, self)._setUp()
    File "/opt/stack/new/neutron/neutron/tests/common/config_fixtures.py", line 55, in _setUp
      self.write_config_to_configfile()
    File "/opt/stack/new/neutron/neutron/tests/common/config_fixtures.py", line 58, in write_config_to_configfile
      config_parser = self.dict_to_config_parser(self.config)
    File "/opt/stack/new/neutron/neutron/tests/common/config_fixtures.py", line 71, in dict_to_config_parser
      config_parser.set(section, option, value)
    File "/usr/lib/python3.5/configparser.py", line 1189, in set
      self._validate_value_types(option=option, value=value)
    File "/usr/lib/python3.5/configparser.py", line 1174, in _validate_value_types
      raise TypeError("option values must be strings")
  TypeError: option values must be strings

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1783095/+subscriptions


References