← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1784604] Re: Redundant join in _anchors_for_sharing_providers

 

Reviewed:  https://review.openstack.org/587377
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1c66a4b029cc9f939f596cd08ae4c20894d3550e
Submitter: Zuul
Branch:    master

commit 1c66a4b029cc9f939f596cd08ae4c20894d3550e
Author: Yikun Jiang <yikunkero@xxxxxxxxx>
Date:   Tue Jul 31 18:27:39 2018 +0800

    Remove redundant join in _anchors_for_sharing_providers
    
    There is a redundant join when we want to get id from
    _anchors_for_sharing_providers. The last outerjoin is used to get the
    rp.UUID according rp.id, if we set get_id=True, we no longer need this
    outer join.
    
    So, we remove the redundant join in this patch.
    
    Change-Id: Ib5fc6e4efae29dd88ce92df834700d2121ed8076
    Closes-bug: #1784604


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1784604

Title:
  Redundant join in  _anchors_for_sharing_providers

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  There is a redundant join when we want to get id from
  _anchors_for_sharing_providers. The last outerjoin is used to get the
  rp.UUID according rp.id [1], if we set get_id=True, we no longer need
  this outer join.

  [1]
  https://github.com/openstack/nova/blob/3ce7fa5/nova/api/openstack/placement/objects/resource_provider.py#L476-L479

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1784604/+subscriptions


References