← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1776373] Re: Invalid obj_make_compatible test case

 

Reviewed:  https://review.openstack.org/574240
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4729fa819675ca511fe0027950d9aadf0aebef1b
Submitter: Zuul
Branch:    master

commit 4729fa819675ca511fe0027950d9aadf0aebef1b
Author: Yikun Jiang <yikunkero@xxxxxxxxx>
Date:   Mon Jun 11 20:30:55 2018 +0800

    Fix all invalid obj_make_compatible test case
    
    We use obj_to_primitive() to generate the primitive obj, the
    origin obj value is primitive['nova_object.data'], so, we need
    transfer primitive to obj data before obj_make_compatible
    called.
    
    This patch fixed all invalid obj_make_compatible test cases.
    
    Closes-Bug: #1776373
    
    Change-Id: I048b22b2447b671228a7ba067e06c59b59e81ce5


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1776373

Title:
  Invalid obj_make_compatible test case

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  (1)
  We use obj_to_primitive() to generate the primitive obj, the
  origin obj value is primitive['nova_object.data'], so, we need
  transfer primitive to obj data before obj_make_compatible
  called.

  (2) Should fix some typo("serial_listen_addr="  -->  "serial_listen_addr") in 
  https://github.com/openstack/nova/blob/master/nova/tests/unit/objects/test_migrate_data.py#L235
  https://github.com/openstack/nova/blob/master/nova/tests/unit/objects/test_migrate_data.py#L240

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1776373/+subscriptions


References