yahoo-eng-team team mailing list archive

[OpenStack Infra <1782746@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/584365
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=2d532963fa2e013e16cc403f2674a4488c4170ab
Submitter: Zuul
Branch:    master

commit 2d532963fa2e013e16cc403f2674a4488c4170ab
Author: Corey Bryant <corey.bryant@xxxxxxxxxxxxx>
Date:   Fri Jul 20 09:01:56 2018 -0400

    In Python3.7 async is a keyword [1]
    
    Change all instances of "async" to "async_"
    
    [1] https://docs.python.org/3/whatsnew/3.7.html
    
    Change-Id: I974b1177ba8313ac502910ca358cf386ef00bc02
    Closes-Bug: #1782746


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1782746

Title:
  py3.7 async is a keyword

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  I'm working on packaging nova for rocky on ubuntu cosmic which is now
  at py3.7. In py3.7 "async" is a keyword, which results in issues such
  as:

  Failed to import test module: nova.tests.unit
  Traceback (most recent call last):
    File "/usr/lib/python3/dist-packages/unittest2/loader.py", line 490, in _find_test_path
      package = self._get_module_from_name(name)
    File "/usr/lib/python3/dist-packages/unittest2/loader.py", line 395, in _get_module_from_name
      __import__(name)
    File "/<<PKGBUILDDIR>>/nova/tests/unit/__init__.py", line 30, in <module>
      objects.register_all()
    File "/<<PKGBUILDDIR>>/nova/objects/__init__.py", line 28, in register_all
      __import__(\'nova.objects.aggregate\')
    File "/<<PKGBUILDDIR>>/nova/objects/aggregate.py", line 23, in <module>
      from nova.db.sqlalchemy import api as db_api
    File "/<<PKGBUILDDIR>>/nova/db/sqlalchemy/api.py", line 218
      reader_mode = get_context_manager(context).async
                                                     ^
  SyntaxError: invalid syntax

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1782746/+subscriptions