yahoo-eng-team team mailing list archive

[OpenStack Infra <1780377@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/580553
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=83dc62ac906be209eda7575b28b476cde69f480e
Submitter: Zuul
Branch:    master

commit 83dc62ac906be209eda7575b28b476cde69f480e
Author: Kristi Nikolla <kristi@xxxxxxxxxx>
Date:   Fri Jul 6 00:25:54 2018 -0400

    Fix keystone-manage saml_idp_metadata under python3
    
    metadata.to_string() was generating a bytes string, which python3
    prepends with b'' when using the print function. Seems like
    removing the to_string() call and just calling print on the object
    makes it work correctly under both python3 and python2.
    
    Change-Id: I546ba0b15f6196be7bbb5940e9f00434d5e6b1ff
    Closes-Bug: #1780377


** Changed in: keystone
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1780377

Title:
  keystone-manage saml_idp_metadata doesn't produce correct output under
  python3

Status in OpenStack Identity (keystone):
  Fix Released

Bug description:
  Discovered this while debugging keystone to keystone tests that were
  failing under python3 (http://logs.openstack.org/41/580041/2/check
  /legacy-keystone-dsvm-py35-functional-v3-only/af33027/)

  The SAML library returns a byte string and python3 prints it out
  including the b prefix causing it to be invalid xml.

  (py3) ubuntu@devstack-mm:/opt/stack/keystone$ keystone-manage saml_idp_metadata
  b'<ns0:EntityDescriptor xmlns:ns0="urn:oasis:names:tc:SAML:2.0:metadata" xmlns:ns1="http://www.w3.org/2000/09/xmldsig#"; entityID="http://192.168.0.6/identity/v3/OS-FEDERATION/saml2/idp";><ns0:IDPSSODescriptor protocolSupportEnumeration="urn:oasis:names:tc:SAML:2.0:protocol"><ns0:KeyDescriptor use="signing"><ns1:KeyInfo><ns1:X509Data><ns1:X509Certificate>MIIFizCCA3OgAwIBAgIJAKDRRvhJJErbMA0GCSqGSIb3DQEBCwUAMFwxCzAJBgNVBAYTAlVTMQ8wDQYDVQQIDAZEZW5pYWwxFDASBgNVBAcMC1NwcmluZ2ZpZWxkMQwwCgYDVQQKDANEaXMxGDAWBgNVBAMMD3d3dy5leGFtcGxlLmNvbTAeFw0xODA3MDUxMzQ0MjRaFw0yMzA3MDUxMzQ0MjRaMFwxCzAJBgNVBAYTAlVTMQ8wDQYDVQQIDAZEZW5pYWwxFDASBgNVBAcMC1NwcmluZ2ZpZWxkMQwwCgYDVQQKDANEaXMxGDAWBgNVBAMMD3d3dy5leGFtcGxlLmNvbTCCAiIwDQYJKoZIhvcNAQEBBQADggIPADCCAgoCggIBAO5p6rG2I3WNzKeCroUOkpcb83jHTugW1ytIs/aTpStak/ltDQCol2qujWBjyuzF3zS4bh/K0IlzDmE+iizgZSrWVqGnC4QHecasy6uytHztq6RmioGLeVSKWcsGMQXvVdoM0BS++j1D/eHuct/GISXYTI7WdKtk7JMWSU4RsNfaKQi9fNSalX7C5dcmvsLaLXx/0s1C5T16F3kiMxPgehxPiGpWtYmIyofBz/1jV7KTszNmBMy8H0J7uAXZE2R4V7nav2LQOeHc6KyquVvbIdhqS0d7X6tmaxGVBaSUGXhJvohBU2AznldxIqfe2NpE3qF+P3g66oyXkOC7Znlx7o3moZYERtVo38xzZ7btrvzWACdndxs8FWE0FzN/qxTqJzYW6pbThOkufAsSL6Dw3MzUY45Q880VcQw+98Z2VybisO4cwLQabASlk/i4CXHo1Ua8uQikUxOwrn2hHIEHyeC4nyYNE6melgvO2rwWETKneuOk5YAure6ZNfWIi3H+H7DXnMfV5Tb0bJ3a1AqVMUEoZkdlfjtpN34Rsac7SmsSj9aeL0b+FdY+EuCb2msX4vp+ZHAniVgTnIflmUdWtOQHgcxHrJKKf2BxP00RIMG/JVnd+XkHewKad6qY28XKK1RewRAl0B1zSnlrmHNAlrrXeWj0c2jyALUjodi3frA3AgMBAAGjUDBOMB0GA1UdDgQWBBSZ0o7n8K7daVP1X+ZoMAKuCk6JazAfBgNVHSMEGDAWgBSZ0o7n8K7daVP1X+ZoMAKuCk6JazAMBgNVHRMEBTADAQH/MA0GCSqGSIb3DQEBCwUAA4ICAQAuveQqI3Wq92ukH3a4SCD3ffokW1j0wals/LSFvPX7WVc5tNzjSZ6lAEBKfIKJnx97OmRY/fPtX/xQzX1TII3AQx/gYZZzZyxI6Tva0kR2kVxhZAoQDcC7jZ/jLcJpoottdiaPAXooO0/118XMTntza2tlxbshcsg6M2N6412eb0DsaaWkw6sHgdW8S4hjT+gRriCyRNqSFWq9T3VNaii38E9hooPj8e3sauiUHlpARMnT9MtLgkGhFkvMRo4dkdvIF3SYiEYlg/8IghR3SEGon6vJK4NY27SuUnwMmFmTu67bzibyuOKaEs4YUPX831HvQSuNNQZUph0RBsLk8a5KSS3/sv/laHpBk4StYcVwp999OJ2pKL/IRnxoVzwiZAZZXtRctVJerWRCSQ6KXeJ+9IlcplJZItRKvd4II64aZGn+Gm3BwqTx8OUjmiFkZNDnvKjjRUrfUHIZwoXa+nOJkOlwyQ0EcWWV2n9pSAyaP0IvG31GZ6kY5ww5zqcdJ2D8EC2Lg/ikcD/QXlC4VRsLecJJaQxYrHtup4rDWuFpDDb+sPuZZfZ/rNix8uY2Dq9jXDWIwWa68o58I4BpB0obuivBdXkasLuQSz11g0Ryamf03ne9XZTX9jIsJWu/R6arjWFWpOzA/nKdWW6Qmc13c5VF23ewLZY/FrgvfJkgaw==</ns1:X509Certificate></ns1:X509Data></ns1:KeyInfo></ns0:KeyDescriptor><ns0:Organization><ns0:OrganizationName xml:lang="en">SAML Identity Provider</ns0:OrganizationName><ns0:OrganizationDisplayName xml:lang="en">OpenStack SAML Identity Provider</ns0:OrganizationDisplayName><ns0:OrganizationURL xml:lang="en">https://example.com/</ns0:OrganizationURL></ns0:Organization><ns0:ContactPerson contactType="other"><ns0:Company>Example, Inc.</ns0:Company><ns0:GivenName>SAML Identity Provider Support</ns0:GivenName><ns0:SurName>Support</ns0:SurName><ns0:EmailAddress>support@xxxxxxxxxxx</ns0:EmailAddress><ns0:TelephoneNumber>+1 800 555 0100</ns0:TelephoneNumber></ns0:ContactPerson><ns0:NameIDFormat>urn:oasis:names:tc:SAML:2.0:nameid-format:transient</ns0:NameIDFormat><ns0:SingleSignOnService Binding="urn:oasis:names:tc:SAML:2.0:bindings:URI" Location="http://192.168.0.6/identity/v3/OS-FEDERATION/saml2/sso"; /></ns0:IDPSSODescriptor></ns0:EntityDescriptor>'
  (py3) ubuntu@devstack-mm:/opt/stack/keystone$

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1780377/+subscriptions