yahoo-eng-team team mailing list archive

[Balazs Gibizer <balazs.gibizer@xxxxxxxxxxxx>]

Public bug reported:

During reverting a resize or a migration Nova still hits the legacy
allocation handling code even if the migration is started without any
old compute or controller in the system. Search for "Doing legacy
allocation math" in [2] for examples.

It is caused by a faulty logic in compute manager[1]. It tries to decide
if the reverted migration holds allocation or not to see if the
migration is a legacy one or not. However in case of [1] the cn_uuid
points to the destination node. Migration never holds allocation on the
destination node so the condition at L3955 never be true and the code
falls to the legacy path.

It seems that the legacy path still able to handled the allocation
properly in the above case so no resource is leaked.

[1] https://github.com/openstack/nova/blob/8688b25ca7379391cba28fab30b5a628957e673e/nova/compute/manager.py#L3952-L3955
[2] http://logs.openstack.org/72/587772/1/check/neutron-tempest-multinode-full/0a2fb57/logs/screen-n-cpu.txt.gz

** Affects: nova
     Importance: Low
     Assignee: Balazs Gibizer (balazs-gibizer)
         Status: New


** Tags: compute resize

** Changed in: nova
   Importance: Undecided => Low

** Changed in: nova
     Assignee: (unassigned) => Balazs Gibizer (balazs-gibizer)

** Tags added: compute

** Tags added: resize

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1785776

Title:
  resize revert still hitting the legacy allocation handling

Status in OpenStack Compute (nova):
  New

Bug description:
  During reverting a resize or a migration Nova still hits the legacy
  allocation handling code even if the migration is started without any
  old compute or controller in the system. Search for "Doing legacy
  allocation math" in [2] for examples.

  It is caused by a faulty logic in compute manager[1]. It tries to
  decide if the reverted migration holds allocation or not to see if the
  migration is a legacy one or not. However in case of [1] the cn_uuid
  points to the destination node. Migration never holds allocation on
  the destination node so the condition at L3955 never be true and the
  code falls to the legacy path.

  It seems that the legacy path still able to handled the allocation
  properly in the above case so no resource is leaked.

  [1] https://github.com/openstack/nova/blob/8688b25ca7379391cba28fab30b5a628957e673e/nova/compute/manager.py#L3952-L3955
  [2] http://logs.openstack.org/72/587772/1/check/neutron-tempest-multinode-full/0a2fb57/logs/screen-n-cpu.txt.gz

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1785776/+subscriptions