yahoo-eng-team team mailing list archive

[OpenStack Infra <1784438@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/587185
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=27f619cf9b82d720ec83f72e02a4821606394829
Submitter: Zuul
Branch:    master

commit 27f619cf9b82d720ec83f72e02a4821606394829
Author: Eddie Ramirez <eddie.ramirez@xxxxxxxxx>
Date:   Mon Jul 30 11:03:02 2018 -0700

    Safer handling of return statement inside of OperationLogMiddleware
    
    Enclosing return statement in a try block. If object is unserializable
    then return a message.
    
    Change-Id: I184f4b10a419037d3ed770fbec42c262f03a89f2
    Closes-bug: #1784438


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1784438

Title:
  Safer handling inside of OperationLogMIddleware when object is
  unserializable

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  function _get_request_param() in
  https://github.com/openstack/horizon/blob/master/horizon/middleware/operation_log.py#L169-L190
  returns a json dump of params that is not always serializable.

  I'm proposing a better handling of the return statement when the
  object "params" is unserializable.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1784438/+subscriptions