yahoo-eng-team team mailing list archive

[Lajos Katona <lajos.katona@xxxxxxxxxxxx>]

I pushed the cherry-picked patch:
https://review.openstack.org/594244

** Project changed: neutron => python-openstackclient

** Changed in: python-openstackclient
     Assignee: (unassigned) => Lajos Katona (lajos-katona)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1778666

Title:
  QoS - “port” parameter is required in CLI in order to set/unset QoS
  policy to floating IP

Status in python-openstackclient:
  Confirmed

Bug description:
  ### User Workflow (Documentation) ###
  According documentation https://docs.openstack.org/neutron/queens/admin/config-qos.html in order to: 

  1) Set QoS to Floating IP:
  openstack floating ip set --qos-policy bw-limiter d0ed7491-3eb7-4c4f-a0f0-df04f10a067c

  2) Remove Floating IP (option 1):
  openstack floating ip set --no-qos-policy d0ed7491-3eb7-4c4f-a0f0-df04f10a067c

  3) Remove Floating IP (option 2)
  openstack floating ip unset --qos-policy d0ed7491-3eb7-4c4f-a0f0-df04f10a067c

  
  ### Testing Result ###

  1) Set QoS to floating IP
  # Scenario #
  openstack floating ip set --no-qos-policy b2895ad6-0e17-4be9-bf03-c11010c81584

  # Actual Result #
  Fails with:
  (openstack) floating ip set --no-qos-policy b2895ad6-0e17-4be9-bf03-c11010c81584
  usage: floating ip set [-h] --port <port> [--fixed-ip-address <ip-address>]
                         [--qos-policy <qos-policy> | --no-qos-policy]
                         <floating-ip>
  floating ip set: error: argument --port is required

  There is no match between “set command” in documentation and implemented code.
  Once “port” parameter is provided, QoS is set as expected.
  “Set command” provided in documentation absolutely OK (“floating-ip” should be a single mandatory parameter),  so the problem here is our implementation.
  I think that we have to check the “Port” value in our code, basing on provided by user “Floating-IP” and then to use it. So this will be kind of workaround and will be transparent to user.

  
  2) Unset QoS from Floating IP with “set –no-qos-policy” option
  # Scenario #
  openstack floating ip set --no-qos-policy b2895ad6-0e17-4be9-bf03-c11010c81584

  # Actual Result #
  Fails with:
  (openstack) floating ip set --no-qos-policy b2895ad6-0e17-4be9-bf03-c11010c81584
  usage: floating ip set [-h] --port <port> [--fixed-ip-address <ip-address>]
                         [--qos-policy <qos-policy> | --no-qos-policy]
                         <floating-ip>
  floating ip set: error: argument --port is required

  Similar to previous “Set QoS”, again no match between the command provided in documentation and our current implementation.
  And again, documentation command is OK, the problem is in our implementation. My suggestion is the same workaround, means getting “Port” from code, basing on provided “Floating IP”

  3) Unset QoS from Floating IP with “unset” option
  # Scenario #
  openstack floating ip unset --qos-policy b2895ad6-0e17-4be9-bf03-c11010c81584

  # Actual Result #
  Works as expected and no “port” value is needed, maybe this info will help the developers to understand why #1 and #2 scenarios behaves diferently.

To manage notifications about this bug go to:
https://bugs.launchpad.net/python-openstackclient/+bug/1778666/+subscriptions