← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1788527] [NEW] Redundant instance group lookup during scheduling of move operations

 

Public bug reported:

This change:

https://github.com/openstack/nova/commit/459ca56de2366aea53efc9ad3295fdf4ddcd452c

Added code to the setup_instance_group flow to get the instance group
fresh so we had the latest hosts for members of the group.

Then change:

https://github.com/openstack/nova/commit/94fd36f0582c5dbcf2b9886da7c7bf986d3ad5d1
#diff-cbbdc4d7c140314a7e0b2d97ebcd1f9c

Was added to not persist group hosts/members in the RequestSpec since
they could be stale after the initial server create. This means when we
move a server (evacuate, resize, unshelve, live migrate), we get the
request spec with the group plus the current hosts/members of the group.
So if the request spec has the group hosts set by the time it gets to
setup_instance_group, the call in _get_group_details to get the group
fresh is redundant.

** Affects: nova
     Importance: Low
         Status: New


** Tags: performance scheduler

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1788527

Title:
  Redundant instance group lookup during scheduling of move operations

Status in OpenStack Compute (nova):
  New

Bug description:
  This change:

  https://github.com/openstack/nova/commit/459ca56de2366aea53efc9ad3295fdf4ddcd452c

  Added code to the setup_instance_group flow to get the instance group
  fresh so we had the latest hosts for members of the group.

  Then change:

  https://github.com/openstack/nova/commit/94fd36f0582c5dbcf2b9886da7c7bf986d3ad5d1
  #diff-cbbdc4d7c140314a7e0b2d97ebcd1f9c

  Was added to not persist group hosts/members in the RequestSpec since
  they could be stale after the initial server create. This means when
  we move a server (evacuate, resize, unshelve, live migrate), we get
  the request spec with the group plus the current hosts/members of the
  group. So if the request spec has the group hosts set by the time it
  gets to setup_instance_group, the call in _get_group_details to get
  the group fresh is redundant.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1788527/+subscriptions


Follow ups