yahoo-eng-team team mailing list archive

[OpenStack Infra <1781151@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/581618
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f5666eed009be13d710f3420954a9cfbb4378c88
Submitter: Zuul
Branch:    master

commit f5666eed009be13d710f3420954a9cfbb4378c88
Author: Shu Muto <shu.mutow@xxxxxxxxx>
Date:   Wed Jul 11 16:56:52 2018 +0900

    Use new style for help in Angular ModalFormService
    
    ModalFormService (horizon.framework.widgets.form.ModalFormService,
    used in create key pair dialog or create user dialog) and WizardModalService
    (horizon.framework.widgets.modal.wizard-modal.service, used in create instance
    dialog or create image dialog) are used in dialogs for create/edit/etc in Angularized
    panel. But their help descriptions are shown in different style.
    
    Angularization proposes new look and feel, so ModalFormService should follow
    new style for help description like WizardModalService.
    
    This patch proposes new style for help in dialogs that uses ModalFormService.
    
    And "?" button for opening help panel is overlaped on input field on the first row,
    so this patch moves it up little bit.
    
    In this new style, if the help contents is too simple, it is not needed to
    make description space in the right harf of dialog for looks consistency,
    it is prefer not to add help panel, i.e. simply do not show "?" button.
    
    Change-Id: Ia720180c7aaef1f3d9c5e24dbebe3fe2d796d6c7
    Closes-Bug: #1781151


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1781151

Title:
  Angular ModalFormService should follow new style for help

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Angular ModalFormService should use new style for help like
  WizardModalService

  ModalFormService (horizon.framework.widgets.form.ModalFormService,
  used in create key pair dialog or create user dialog) and
  WizardModalService (horizon.framework.widgets.modal.wizard-
  modal.service, used in create instance dialog or create image dialog)
  are used in dialogs for create/edit/etc in Angularized panel. But
  their help descriptions are shown in different style.

  Angularization proposes new look and feel, so ModalFormService should
  follow new style for help description like WizardModalService.

  Discussed at followings:
  Comments in https://review.openstack.org/#/c/537336/
  L181 in https://etherpad.openstack.org/p/horizon-ptg-rocky

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1781151/+subscriptions