yahoo-eng-team team mailing list archive

[OpenStack Infra <1774460@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/571554
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d62d82b0fe4052983f9fa2408f08b9c5673e75bf
Submitter: Zuul
Branch:    master

commit d62d82b0fe4052983f9fa2408f08b9c5673e75bf
Author: Mykola Yakovliev <VegasQ@xxxxxxxxx>
Date:   Thu May 31 13:25:26 2018 -0500

    Generate correct url in api pagination
    
    Use protocol from X-Forwarded-Proto, and not from current endpoint.
    
    Change-Id: I3fafc4ef1cf56cb8f1cddc1a003a755e3f93c75c
    Closes-Bug: 1774460


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1774460

Title:
  Neutron pagination ignores X-Forwarded-Proto header

Status in neutron:
  Fix Released

Bug description:
  In our setup HAProxy implements https, with http at the backend. But
  due to incorrect behavior, api pagination returns incorrect protocol.

  f.e.

  curl -g -i -X GET "https://network.lab.att.com:9696/v2.0/subnets.json?fields=<...>&limit=2" \
  -H "User-Agent: python-neutronclient" \
  -H "Accept: application/json" \
  -H "X-Auth-Token: <token>"

  
  {
  "subnets": [
      {"cidr": "18.1.1.0/24", "id": "bf2df430-47a5-420d-0000-c9a62936b996"},
      {"cidr": "20.20.10.0/24", "id": "93051c51-48e6-4ac1-0000-3d3f0978aa72"}
  ],
  "subnets_links": [
      {
          "href": "http://network.lab.att.com:9696/v2.0/subnets.json?fields=<...>&limit=2&marker=93051c51-48e6-4ac1-0000-3d3f0978aa72",
          "rel": "next"},
      {
          "href": "http://network.lab.att.com:9696/v2.0/subnets.json?fields=<...>&limit=2&marker=bf2df430-47a5-420d-0000-c9a62936b996&page_reverse=True",
          "rel": "previous"
      }
  ]
  }

  As you may see in response we have http urls, instead of https.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1774460/+subscriptions