← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1761036] Re: Navigation on ngdetails is not reproduced properly when specified navigation is not exist

 

Reviewed:  https://review.openstack.org/580113
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=8c03ce0bcc56631752da0cfb6d3fdf261b238a20
Submitter: Zuul
Branch:    master

commit 8c03ce0bcc56631752da0cfb6d3fdf261b238a20
Author: Shu Muto <shu.mutow@xxxxxxxxx>
Date:   Wed Jul 4 16:29:36 2018 +0900

    Move to 404 page if specified navigation not found
    
    When refresh or link directly to ngdetails without correct navigation
    to be set, ngdetails view can not reproduce navigations, i.e. sidebar
    and breadcrumb.
    e.g. when the ordinary user try to open the URL specified as admin side.
    
    In this situation, ngdetails view should show 404 page.
    So this patch move to 404 page if the navigation does not exist.
    
    Change-Id: I7aeeddf838923d110703bfd7a04699b056c2abd5
    Closes-Bug: #1761036


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1761036

Title:
  Navigation on ngdetails is not reproduced properly when specified
  navigation is not exist

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  This issue is caused by https://review.openstack.org/#/c/491346/ that
  fixed the bug https://bugs.launchpad.net/horizon/+bug/1746706/ , when
  the navigation does not have specified panel originally.

  e.g. when the non-admin user who does not have menu for "Admin" dashboard specifies "?nav=/admin/images/" at the end of URL, like http://host.domain/ngdetails/OS::Glance::Image/ce46ef50-850a-46ed-8707-bd5b21e4f9b7?nav=%2Fadmin%2Fimages%2F .
  It means to reproduce navigation for the ngdetails view as on "Admin" dashboard.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1761036/+subscriptions


References