← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1794545] Re: PlacementAPIClient.update_resource_class wrong client call, missing argument

 

Reviewed:  https://review.openstack.org/605455
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=691cd287ba7457aa4fdae100620f2ca8f11400ed
Submitter: Zuul
Branch:    master

commit 691cd287ba7457aa4fdae100620f2ca8f11400ed
Author: Rodolfo Alonso Hernandez <ralonsoh@xxxxxxxxxx>
Date:   Wed Sep 26 16:11:55 2018 +0100

    PlacementAPIClient.update_resource_class client call missing argument
    
    "PlacementAPIClient.update_resource_class" is calling Placement client
    "put" method with a missing argument, "data". In this call, "data"
    should be None [1], but it's a positional argument and must be passed.
    
    [1] https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/microversion.py#L41
    
    Change-Id: Iedcad7c81a913923506bed2762b60b094f2d601d
    Closes-Bug: #1794545


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1794545

Title:
  PlacementAPIClient.update_resource_class wrong client call, missing
  argument

Status in neutron:
  Fix Released

Bug description:
  "PlacementAPIClient.update_resource_class" is calling Placement client
  "put" method with a missing argument, "data". In this call, "data"
  should be None [1], but it's a positional argument and must be passed.

  [1]
  https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/microversion.py#L41

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1794545/+subscriptions


References