yahoo-eng-team team mailing list archive

[OpenStack Infra <1795078@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/606213
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=020651ad3d14066af34dc5d1d96cec7c6ffe5cd9
Submitter: Zuul
Branch:    master

commit 020651ad3d14066af34dc5d1d96cec7c6ffe5cd9
Author: melanie witt <melwittt@xxxxxxxxx>
Date:   Fri Sep 28 22:07:42 2018 +0000

    Replace usage of get_legacy_facade() with get_engine()
    
    We've been seeing warnings emitted to the python 3 unit tests:
    
      OsloDBDeprecationWarning: EngineFacade is deprecated; please use
      oslo_db.sqlalchemy.enginefacade
    
    which stem from our use of the get_legacy_facade() oslo.db method.
    
    This replaces the get_legacy_facade() usage with the get_engine()
    method from the transaction context manager.
    
    Closes-Bug: #1795078
    
    Change-Id: If1e355d6174f15a1880e97115a2cf3f9f4be837e


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1795078

Title:
  "OsloDBDeprecationWarning: EngineFacade is deprecated; please use
  oslo_db.sqlalchemy.enginefacade" warnings emitted numerous times
  during py3 unit tests

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Seen in the openstack-tox-py35 [1]:

  2018-09-26 17:20:32.001487 | ubuntu-xenial | /home/zuul/src/git.openstack.org/openstack/nova/.tox/py35/lib/python3.5/site-packages/oslo_db/sqlalchemy/enginefacade.py:350: OsloDBDeprecationWarning: EngineFacade is deprecated; please use oslo_db.sqlalchemy.enginefacade
  2018-09-26 17:20:32.001833 | ubuntu-xenial |   self._legacy_facade = LegacyEngineFacade(None, _factory=self)

  and openstack-tox-py36 jobs:

  2018-09-28 11:39:03.066777 | ubuntu-bionic |     b'/home/zuul/src/git.openstack.org/openstack/nova/.tox/py36/lib/python3.6/site-packages/oslo_db/sqlalchemy/enginefacade.py:350: OsloDBDeprecationWarning: EngineFacade is deprecated; please use oslo_db.sqlalchemy.enginefacade'
  2018-09-28 11:39:03.066944 | ubuntu-bionic |     b'  self._legacy_facade = LegacyEngineFacade(None, _factory=self)'

  [1] http://logs.openstack.org/97/410297/44/gate/openstack-tox-py35/9d96763/job-output.txt#_2018-09-26_17_14_52_089548
  [2] http://logs.openstack.org/16/270116/18/check/openstack-tox-py36/56e7491/job-output.txt.gz#_2018-09-28_11_39_03_066777

  I think this issue stems from our use of the get_legacy_facade()
  method in the DB API, so we need to update to use the get_engine()
  method from the transaction context manager class instead.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1795078/+subscriptions