yahoo-eng-team team mailing list archive

[Launchpad Bug Tracker <1778771@xxxxxxxxxxxxxxxxxx>]

This bug was fixed in the package horizon - 3:14.0.0-0ubuntu4

---------------
horizon (3:14.0.0-0ubuntu4) cosmic; urgency=medium

  * d/p/add-enabled-check-in-backups-panel.patch: Cherry-picked from
    https://review.openstack.org/#/c/605715 to ensure Volume Backups panel
    is disabled if enable_backup is False (LP: #1778771).

 -- Corey Bryant <corey.bryant@xxxxxxxxxxxxx>  Mon, 01 Oct 2018 15:04:31
-0400

** Changed in: horizon (Ubuntu Cosmic)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1778771

Title:
  Backups panel is visible even if enable_backup is False

Status in OpenStack openstack-dashboard charm:
  In Progress
Status in Ubuntu Cloud Archive:
  Fix Committed
Status in Ubuntu Cloud Archive queens series:
  Triaged
Status in Ubuntu Cloud Archive rocky series:
  Fix Committed
Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in horizon package in Ubuntu:
  Fix Released
Status in horizon source package in Bionic:
  Triaged
Status in horizon source package in Cosmic:
  Fix Released

Bug description:
  Hi,

  Volumes - Backup panel is visible even if OPENSTACK_CINDER_FEATURES =
  {'enable_backup': False} in local_settings.py

  Meanwhile setting enable_backup to false removes an option to create
  backup of a volume in the volume drop-down options. But panel with
  backups itself stays visible for both admins and users.

  As a work-around I use the following customization script:
  import horizon
  from django.conf import settings
  if not getattr(settings, 'OPENSTACK_CINDER_FEATURES', {}).get('enable_backup', False):
      project = horizon.get_dashboard("project")
      backup = project.get_panel("backups")
      project.unregister(backup.__class__)

  And for permanent fix I see the following decision. In openstack_dashboard/dashboards/project/backups/panel.py make the following changes:
  ...
  +L16: from django.conf import settings
  ...
  +L21:     if not getattr(settings, 'OPENSTACK_CINDER_FEATURES', {}).get('enable_backup', False):
  +L22:         return False
  ...

To manage notifications about this bug go to:
https://bugs.launchpad.net/charm-openstack-dashboard/+bug/1778771/+subscriptions