yahoo-eng-team team mailing list archive

[Morgan Fainberg <morgan.fainberg@xxxxxxxxx>]

In line with my comment on the proposed change:

I am not a fan of wrapping basic functions in python with extra layers
for the sake of extra layers.

I also do not think the is_uuid_like is strict enough for what we do in
keystone. is_uuid_like would need to have a strict enforcement that no
dashes are allowed for many of our storage cases if we were to lean on
it.

---

With the way keystone is setup, if someone were to change the underlying
id generator, it is possible that you could break all of keystone due to
how we've structured our expectations of IDs when they are auto
generated.

I'm going to hold with a firm -1. Bordering on a -2.

Unless there is a real drive to see some level of consistency
specifically for a uuid generation and we (as keystone) have high levels
of assurances that the function will never change (Even by accident), I
don't foresee changing my stance on this.

This holds especially true with some of the upcoming changes where we
are going to no longer generate explicitly uuids but utilize a
combination hashing mechanism to provide better IDs (in the case of
users). For now, this change is not consistent with the design of
Keystone.


---

I am moving this to an opinion. It is not in line with the general
direction of Keystone, but I can be convinced (longer term) to change my
-1 depending on the overall direction of OpenStack projects (if there is
a real drive for consistency on resource id generation).


** Changed in: keystone
       Status: In Progress => Opinion

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1792868

Title:
  Use uuidutils instead of uuid.uuid4()

Status in OpenStack Identity (keystone):
  Opinion

Bug description:
  oslo_utils.uuidutils has a wrapper for generating uuids.
  We should only use that function when generating
  uuids for consistency like here:https://storyboard.openstack.org/#!/story/1082248.

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1792868/+subscriptions