← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1796857] [NEW] ImagePropertiesFilter docs refer to legacy properties

 

Public bug reported:

https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#imagepropertiesfilter
refers to the 'architecture', 'hypervisor_type',
'hypervisor_version_requires', and 'vm_mode' properties; however the
source code at
https://github.com/openstack/nova/blob/05c379173569d2ea91741f3468d531d4edf7ef9d/nova/objects/image_meta.py#L474
shows that these are legacy properties which now have preferred
alternatives:

    # The keys are the legacy property names and
    # the values are the current preferred names
    _legacy_property_map = {
        'architecture': 'hw_architecture',
        [... snipped ...]
        'vm_mode': 'hw_vm_mode',
        [... snipped ...]
        'hypervisor_version_requires': 'img_hv_requested_version',
        'hypervisor_type': 'img_hv_type',
    }

Therefore presumably the docs should be updated to refer to the new
properties.  If someone can confirm this is correct, I'm happy to push
the doc fix for review.

** Affects: nova
     Importance: Undecided
         Status: New


** Tags: doc

** Summary changed:

- ImagePropertiesFilter refers to legacy properties
+ ImagePropertiesFilter docs refer to legacy properties

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1796857

Title:
  ImagePropertiesFilter docs refer to legacy properties

Status in OpenStack Compute (nova):
  New

Bug description:
  https://docs.openstack.org/nova/latest/admin/configuration/schedulers.html#imagepropertiesfilter
  refers to the 'architecture', 'hypervisor_type',
  'hypervisor_version_requires', and 'vm_mode' properties; however the
  source code at
  https://github.com/openstack/nova/blob/05c379173569d2ea91741f3468d531d4edf7ef9d/nova/objects/image_meta.py#L474
  shows that these are legacy properties which now have preferred
  alternatives:

      # The keys are the legacy property names and
      # the values are the current preferred names
      _legacy_property_map = {
          'architecture': 'hw_architecture',
          [... snipped ...]
          'vm_mode': 'hw_vm_mode',
          [... snipped ...]
          'hypervisor_version_requires': 'img_hv_requested_version',
          'hypervisor_type': 'img_hv_type',
      }

  Therefore presumably the docs should be updated to refer to the new
  properties.  If someone can confirm this is correct, I'm happy to push
  the doc fix for review.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1796857/+subscriptions