yahoo-eng-team team mailing list archive

[OpenStack Infra <1795982@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/607068
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=b49209cc29f5ccd529b8074b68be074c5a2f742f
Submitter: Zuul
Branch:    master

commit b49209cc29f5ccd529b8074b68be074c5a2f742f
Author: melanie witt <melwittt@xxxxxxxxx>
Date:   Mon Oct 1 23:47:28 2018 +0000

    Use nova-consoleauth only if workaround enabled
    
    In Rocky, we deprecated the nova-consoleauth service but there were
    unconditional calls to nova-consoleauth in the compute/api, which
    made it impossible to avoid running the nova-consoleauth service.
    
    This adds conditional checks to call nova-consoleauth only if the
    [workarounds]enable_consoleauth configuration option is True. The
    option defaults to False because the default console token auth TTL
    is 10 minutes and only operators who have configured much longer TTL
    or otherwise wish to avoid resetting all consoles at upgrade time
    need to use the option.
    
    This also updates the /os-console-auth-tokens/{console_token} API to
    use nova-consoleauth only if the [workarounds] option is enabled. This
    had to be done in the same change because the conditional checks in
    the compute/api code caused the /os-console-auth-tokens API functional
    tests to fail to find token authorizations in nova-consoleauth.
    
    Closes-Bug: #1788470
    Closes-Bug: #1795982
    
    Change-Id: Iff6020f1a10afc476864f979faf251ef5a1a6184


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1795982

Title:
  /os-console-auth-tokens/{console_token} API doesn't handle the
  database backend

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  In Rocky, we deprecated the nova-consoleauth service, but it's still
  being called in the compute/api [1], which requires it to be run
  currently despite being deprecated.

  In addition to that, today I found that the /os-console-auth-
  tokens/{console_token} API [2] assumes the nova-consoleauth backend
  and does nothing to handle the database backend. Since the only
  request parameter is the auth token, we can't know which cell database
  the token auth resides in, so at best we would have to scatter-gather
  all cells to get the console connection information to return.

  [1] https://launchpad.net/bugs/1788470
  [2] https://developer.openstack.org/api-ref/compute/#show-console-connection-information

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1795982/+subscriptions