← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1796981] Re: nova/compute/manager.py throws TypeError: 'NoneType' object is not iterable

 

Reviewed:  https://review.openstack.org/609518
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=4da54c07861a1542a8e30a768d4506d3e81b5598
Submitter: Zuul
Branch:    master

commit 4da54c07861a1542a8e30a768d4506d3e81b5598
Author: Matt Riedemann <mriedem.os@xxxxxxxxx>
Date:   Wed Oct 10 15:07:00 2018 -0400

    Fix NoneType error in _notify_volume_usage_detach
    
    If the driver.block_stats() method returns None, like the
    libvirt driver will if the guest is gone during an evacuate,
    we'll get a NoneType error trying to unpack the return value
    from the driver. Instead, simply return as if the driver
    raised NotImplementedError.
    
    Since handling None is changing the contract on the virt
    driver API, the docstring is updated to explain the acceptable
    return values of the driver method.
    
    Change-Id: I98a2785c07f7af02ad83650c72d9e1868290ece4
    Closes-Bug: #1796981


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1796981

Title:
  nova/compute/manager.py throws TypeError: 'NoneType' object is not
  iterable

Status in OpenStack Compute (nova):
  Fix Released
Status in OpenStack Compute (nova) ocata series:
  Triaged
Status in OpenStack Compute (nova) pike series:
  Triaged
Status in OpenStack Compute (nova) queens series:
  Triaged
Status in OpenStack Compute (nova) rocky series:
  Triaged

Bug description:
  Problem Description: Nova evacuate <instance_id> <target_host_name>
  fails, instances reported in ERROR state after executing “nova
  evacuate”

  Summary: A instance with its boot volume on a shared storage device (
  HP 3Par or SUSE CEPH cluster ) errors out during a evacuate. By making
  a code change to catch the error dereferencing vol_stats in
  nova/compute/manager.py the error can be avoided.

  Included: 
  * Steps to produce it
  * nova evacuate with --debug 
  * Command line output showing the state of the VM before and after the evacuate
  * code that was changed 
  * Command line output showing the successful state of the VM before and after the evacuate

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1796981/+subscriptions


References