← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1797309] Re: Every item in navigation bar of workflow form should be hide if the parameter ready is false

 

Reviewed:  https://review.openstack.org/608907
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=35a718a511a987ed5038561a0650de485520b8d5
Submitter: Zuul
Branch:    master

commit 35a718a511a987ed5038561a0650de485520b8d5
Author: shutingm <shutingm@xxxxxxxxxx>
Date:   Tue Oct 9 17:45:22 2018 +0800

    Workflow uses parameter "viewModel.ready" to do the repetitive work.
    
    In workflow module, every item in navigation used
    'ng-show="viewModel.ready"' to determine whether it should
    be display, it makes no sense to do so, and should replace
    with the item parameter "step.ready" to control itself show
    or hide.
    
    Change-Id: Iadc5c90995022b2e0a13bcd46e4f2de64d1088b5
    Closes-bug: #1797309


** Changed in: horizon
       Status: Confirmed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1797309

Title:
  Every item in navigation bar of workflow form should be  hide if the
  parameter ready is false

Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in horizon package in Ubuntu:
  New

Bug description:
  In workflow wizard, every item of navigation used parameter 'ng-show="viewModel.ready"' to determine whether it should be display. I think it should use the parameter 'ready' of every item,
  like this: 'ng-show="step.ready"'. I think it make sense.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1797309/+subscriptions