yahoo-eng-team team mailing list archive

[Federico Ressi <1801306@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

I found a couple of race conditions in neutron-tempest-plugin affecting
recular CI build when executing test jobs with neutron-tempest-plugin
test suite. These race conditions are mostly because two test case
wrongly modify default security group causing random failures in other
scenario test cases or also failing themself.

1) Test case test_default_sec_grp_scenarios shouldn't change default security group rule at below lines:
https://github.com/openstack/neutron-tempest-plugin/blob/cf38b77328dbf94f1323f96f68aa77124a6f4a7b/neutron_tempest_plugin/scenario/test_security_groups.py#L109-L112
This could caouse other tests to fail. Modifying default resources should be forbidden. There is no difference between default security group and another group, therefore the test makes no sense at all. Tests that do some changes on resources should create its own target resources.

 
2) Test case test_protocol_number_rule list for security groups and takes the first one, then it changes it at line
https://github.com/openstack/neutron-tempest-plugin/blob/cf38b77328dbf94f1323f96f68aa77124a6f4a7b/neutron_tempest_plugin/scenario/test_security_groups.py#L147-L149
The problem here is that the first security group that is taken could be the default security group instead of the one created by the test. This would cause a failure in the same test and even worst in another test later.

** Affects: neutron
     Importance: Undecided
     Assignee: Federico Ressi (fressi-redhat)
         Status: In Progress

** Changed in: neutron
     Assignee: (unassigned) => Federico Ressi (fressi-redhat)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1801306

Title:
  Race conditions in
  neutron_tempest_plugin/scenario/test_security_groups.py

Status in neutron:
  In Progress

Bug description:
  I found a couple of race conditions in neutron-tempest-plugin
  affecting recular CI build when executing test jobs with neutron-
  tempest-plugin test suite. These race conditions are mostly because
  two test case wrongly modify default security group causing random
  failures in other scenario test cases or also failing themself.

  1) Test case test_default_sec_grp_scenarios shouldn't change default security group rule at below lines:
  https://github.com/openstack/neutron-tempest-plugin/blob/cf38b77328dbf94f1323f96f68aa77124a6f4a7b/neutron_tempest_plugin/scenario/test_security_groups.py#L109-L112
  This could caouse other tests to fail. Modifying default resources should be forbidden. There is no difference between default security group and another group, therefore the test makes no sense at all. Tests that do some changes on resources should create its own target resources.

   
  2) Test case test_protocol_number_rule list for security groups and takes the first one, then it changes it at line
  https://github.com/openstack/neutron-tempest-plugin/blob/cf38b77328dbf94f1323f96f68aa77124a6f4a7b/neutron_tempest_plugin/scenario/test_security_groups.py#L147-L149
  The problem here is that the first security group that is taken could be the default security group instead of the one created by the test. This would cause a failure in the same test and even worst in another test later.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1801306/+subscriptions