← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1796824] Re: Port in some type of device_owner should not allow update IP address

 

Reviewed:  https://review.openstack.org/612969
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=cd2c69890b042b0aa3df07de2c53f294e04a390d
Submitter: Zuul
Branch:    master

commit cd2c69890b042b0aa3df07de2c53f294e04a390d
Author: LIU Yulong <i@xxxxxxxxxxxx>
Date:   Wed Oct 24 17:39:36 2018 +0800

    Add shim extension l3-port-ip-change-not-allowed
    
    Change-Id: I3578ef48432792aca25acf7c30413d79a0fd4065
    Closes-Bug: #1796824


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1796824

Title:
  Port in some type of device_owner should not allow update IP address

Status in neutron:
  Fix Released

Bug description:
  Some L3 ports can now be directly modify the IP address, but there are
  some type of device_owner, for instance
  network:router_centralized_snat, should not allow to change the IP
  address, otherwise it will make things really complicated.

  Step to reproduce, update dvr router network:router_centralized_snat port directly:
  $ openstack port show 85ffe5a3-4332-4864-8ea5-5b13f3c7f63f
  +-----------------------+-------------------------------------------------------------------------------+
  | Field                 | Value                                                                         |
  +-----------------------+-------------------------------------------------------------------------------+
  | admin_state_up        | UP                                                                            |
  | allowed_address_pairs |                                                                               |
  | binding_host_id       | node3                                                                         |
  | binding_profile       |                                                                               |
  | binding_vif_details   | datapath_type='system', ovs_hybrid_plug='False', port_filter='True'           |
  | binding_vif_type      | ovs                                                                           |
  | binding_vnic_type     | normal                                                                        |
  | created_at            | 2018-09-19T09:48:58Z                                                          |
  | data_plane_status     | None                                                                          |
  | description           |                                                                               |
  | device_id             | 867e1473-4495-4513-8759-dee4cb1b9cef                                          |
  | device_owner          | network:router_centralized_snat                                               |
  | dns_assignment        | None                                                                          |
  | dns_name              | None                                                                          |
  | extra_dhcp_opts       |                                                                               |
  | fixed_ips             | ip_address='192.168.188.13', subnet_id='0bbb326f-91c7-4030-9425-bc994a25db84' |
  | id                    | 85ffe5a3-4332-4864-8ea5-5b13f3c7f63f                                          |
  | ip_address            | None                                                                          |
  | mac_address           | fa:16:3e:1e:01:f8                                                             |
  | name                  |                                                                               |
  | network_id            | f5c2435f-4096-4b91-8211-e3e22e08233a                                          |
  | option_name           | None                                                                          |
  | option_value          | None                                                                          |
  | port_security_enabled | False                                                                         |
  | project_id            |                                                                               |
  | qos_policy_id         | None                                                                          |
  | revision_number       | 266                                                                           |
  | security_group_ids    |                                                                               |
  | status                | ACTIVE                                                                        |
  | subnet_id             | None                                                                          |
  | tags                  |                                                                               |
  | trunk_details         | None                                                                          |
  | updated_at            | 2018-10-02T06:46:46Z                                                          |
  +-----------------------+-------------------------------------------------------------------------------+
  $ openstack port set  --fixed-ip subnet=0bbb326f-91c7-4030-9425-bc994a25db84,ip-address=192.168.188.100 85ffe5a3-4332-4864-8ea5-5b13f3c7f63f

  $ openstack port unset  --fixed-ip subnet=0bbb326f-
  91c7-4030-9425-bc994a25db84,ip-address=192.168.188.13
  85ffe5a3-4332-4864-8ea5-5b13f3c7f63f

  $ openstack port show 85ffe5a3-4332-4864-8ea5-5b13f3c7f63f
  +-----------------------+--------------------------------------------------------------------------------+
  | Field                 | Value                                                                          |
  +-----------------------+--------------------------------------------------------------------------------+
  | admin_state_up        | UP                                                                             |
  | allowed_address_pairs |                                                                                |
  | binding_host_id       | node3                                                                          |
  | binding_profile       |                                                                                |
  | binding_vif_details   | datapath_type='system', ovs_hybrid_plug='False', port_filter='True'            |
  | binding_vif_type      | ovs                                                                            |
  | binding_vnic_type     | normal                                                                         |
  | created_at            | 2018-09-19T09:48:58Z                                                           |
  | data_plane_status     | None                                                                           |
  | description           |                                                                                |
  | device_id             | 867e1473-4495-4513-8759-dee4cb1b9cef                                           |
  | device_owner          | network:router_centralized_snat                                                |
  | dns_assignment        | None                                                                           |
  | dns_name              | None                                                                           |
  | extra_dhcp_opts       |                                                                                |
  | fixed_ips             | ip_address='192.168.188.100', subnet_id='0bbb326f-91c7-4030-9425-bc994a25db84' |
  | id                    | 85ffe5a3-4332-4864-8ea5-5b13f3c7f63f                                           |
  | ip_address            | None                                                                           |
  | mac_address           | fa:16:3e:1e:01:f8                                                              |
  | name                  |                                                                                |
  | network_id            | f5c2435f-4096-4b91-8211-e3e22e08233a                                           |
  | option_name           | None                                                                           |
  | option_value          | None                                                                           |
  | port_security_enabled | False                                                                          |
  | project_id            |                                                                                |
  | qos_policy_id         | None                                                                           |
  | revision_number       | 270                                                                            |
  | security_group_ids    |                                                                                |
  | status                | ACTIVE                                                                         |
  | subnet_id             | None                                                                           |
  | tags                  |                                                                                |
  | trunk_details         | None                                                                           |
  | updated_at            | 2018-10-09T08:27:55Z                                                           |
  +-----------------------+--------------------------------------------------------------------------------+

  Nothing happened in L3 agent side.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1796824/+subscriptions


References