yahoo-eng-team team mailing list archive

[OpenStack Infra <1802369@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/617119
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=593c04d10d9d67cc6f864ff37416951dd28584f5
Submitter: Zuul
Branch:    master

commit 593c04d10d9d67cc6f864ff37416951dd28584f5
Author: Slawek Kaplonski <skaplons@xxxxxxxxxx>
Date:   Sat Nov 10 15:48:20 2018 +0100

    Import neutron.db.api module in common.utils
    
    Patch [1] removed import of neutron.db.api module in
    neutron.common.utils.
    This cause some issues e.g. in networking-ovn projects because
    listeners:
    
    @event.listens_for(orm.session.Session, "persistent_to_deleted")
    on _persistent_to_deleted() function [2] and
    
    @event.listens_for(model_base.BASEV2, "attribute_instrument", propagate=True)
    on _listen_for_changes() function [3]
    
    aren't created as they where before.
    
    This patch adds import of this neutron.db.api module again just to
    ensure that those listeners are created properly.
    
    [1] https://review.openstack.org/#/c/614252/
    [2] https://github.com/openstack/neutron/blob/master/neutron/db/api.py#L110
    [3] https://github.com/openstack/neutron/blob/master/neutron/db/api.py#L134
    
    Closes-Bug: #1802369
    
    Change-Id: I3e427ee5c904c34115aaf1afa67e1109ea58d603


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1802369

Title:
  Unit tests failing due to recent Neutron patch

Status in networking-ovn:
  New
Status in neutron:
  Fix Released

Bug description:
  Since Nov 7th we have unit tests failing. I've doing git bisect on
  neutron and found that [0] is the culprit. Digging further I checked
  that it's not actually that MAX_RETRIES changed from 10 (neutron code)
  to 20 (neutron-lib) but the fact that "from neutron.db import api as
  db_api" is no longer imported.

  
  [0] https://github.com/openstack/neutron/commit/3316b45665a99b0f61e45a8c7facf538618861bf

To manage notifications about this bug go to:
https://bugs.launchpad.net/networking-ovn/+bug/1802369/+subscriptions