← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1792778] Re: Inconsistent use of btn-danger

 

Reviewed:  https://review.openstack.org/618096
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=55835c7305b52f03f8d391f5715ff8d3b75177d2
Submitter: Zuul
Branch:    master

commit 55835c7305b52f03f8d391f5715ff8d3b75177d2
Author: manchandavishal <manchandavishal143@xxxxxxxxx>
Date:   Thu Nov 15 07:45:56 2018 +0000

    Fix: Inconsistent use of btn-danger
    
    The color of delete image button is inconsistent with other
    destructive buttons.
    This patch fixes the issue.
    
    Change-Id: Id7acd54e5535912eff4e69cbfd360ef02e7d8786
    Closes-Bug: #1792778


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1792778

Title:
  Inconsistent use of btn-danger

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  I think this started in queens as a result of:
  https://review.openstack.org/#/c/339278/

  This changed some delete confirmation buttons from btn-primary to btn-
  danger. However, some buttons, such as "Delete Image", still uses btn-
  primary. This results in inconsistent colors for destructive buttons
  on confirmation modals.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1792778/+subscriptions


References